Firefly 1354 timeseries save table filename

[wmiipac]

View ticket for details. I added two test files in the ticket for testing purpose.

To test:
https://firefly-1354-ts.irsakudev.ipac.caltech.edu/irsaviewer/ts.html

1. upload ztt-ts.tbl or wise-ts.tbl
2. follow the steps in Luisa's video, by applying filter on the chart, then save the filtered table
3. in the ztf case the table will be saved as table_ztf-Input-Data.tbl, for wise upload table name is table_wise-Input-Data.
4. if an unspecified mission data is uploaded, there will be no mission name in the table name: table_Input-Data. I am open to suggestions.

[kpuriIpac]

Changes look good, I made a comment about mission names possibly being capitalized. But even after that, a potential filename would look like:

table_WISE-Input-Data.tbl

Per the guide on confluence, I think the part WISE-Input-Data is fine as WISE is the mission name and Input Data is the table name, and since they're space separated, we use hyphens in the file name as mentioned in the guide.

But I think firefly's makeFileRequest adds the table_ prefix which not only looks awkward as is but also uses underscore (which when combined with hyphens in the file name is odd). If you want, I can take a look at that if it falls outside scope of this ticket.

For unspecified missions, I think it's fine to have table in there (but possibly still better to just have the actual table name, in this case Input Data), but that again is probably a fix in makeFileRequest in firefly.

[kpuriIpac]

suggestion: should we capitalize mission name so that ztf becomes ZTF, wise becomes WISE, and so on?

[lrebull]

still broken for me -- see video -- it happens when i launch the timeseries tool from ztf search results.

video1446798995.mp4

[wmiipac]

@lrebull Now I understand you are send the ts data from Gator to ts tool not with the ts upload panel. I will look into the api call sent to ts from backend ( the g2p cgi call).

[wmiipac]

Per the guide on confluence, I think the part WISE-Input-Data is fine as WISE is the mission name and Input Data is the table name, and since they're space separated, we use hyphens in the file name as mentioned in the guide.

@kpuriIpac I thought about using upper case for mission name, but in the case of sending ts api from catalog search we have to use convertId which is defined in lower case. For the consistency, we just have them in lower case, if there is no strong objection

[kpuriIpac]

@kpuriIpac I thought about using upper case for mission name, but in the case of sending ts api from catalog search we have to use convertId which is defined in lower case. For the consistency, we just have them in lower case, if there is no strong objection

Yes, I'm good with that!

[wmiipac]

@kpuriIpac currently save table and chart files are prefixed with table_ and chart_ , could change the underscore to dash

[kpuriIpac]

@kpuriIpac currently save table and chart files are prefixed with table_ and chart_ , could change the underscore to dash

I think since we change any spaces in file names to hyphens (like Input Data becomes Input-Data) when saving files, I think that change would make sense?

[lrebull]

looks great to me.