-
Notifications
You must be signed in to change notification settings - Fork 253
Various fixes, with a view toward the vscode extension #3845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
133d482
to
5ab3488
Compare
this gtest stuff is driving me insane. it seems each time I have a new commit, it silently changes gtest and it's not clear why / how to know about it. |
6185d7a
to
b22fde8
Compare
OK this might be enough for a PR.
|
A few notes about this.
@pzinn Do you want to make any other changes for the moment, before this gets accepted? |
@d-torrance Do you see any issues with the changes to use of stdin and stderr? It seems that since this is done only for webapp mode, it should not be a problem? |
thanks for testing @mikestillman. Yeah it's not perfect yet (in particular when it comes to
You're right that code in examples is not properly parsed -- unfortunately this is the way examples are currently produced, as a block rather than with separate input/output. On my vanilla branch, help examples are produced in webapp mode, which automatically inserts all the character codes that allow to distinguish say input from output. I would say this PR is enough as it is. Unless there's a problem with it, it's ready to be merged. |
This branch has two purposes:
npm start local
) or more importantly to use Macaulay2 in the newly developed vscode extension, with the same quality of rendering as with the forked branch (vanilla) used on the official Macaulay2Web server.This is very much work in progress.