Added New Methods to WhitneyStratifications and CharacteristicClasses packages #3894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new methods for computation of Whitney stratification via polar varieties as well as methods to compute the Euler characteristic of the complex link and the local Euler obstruction using Whitney stratification.
Added affine Euler characteristic method to CharacteristicClasses package.
d-torrance
requested changes
Jun 23, 2025
| @@ -22,6 +22,7 @@ newPackage( | |||
| "published article URI" => "https://msp.org/jsag/2015/7-1/p04.xhtml", | |||
| "published article DOI" => "10.2140/jsag.2015.7.31", | |||
| "published code URI" => "https://msp.org/jsag/2015/7-1/jsag-v7-n1-x04-CharacteristicClasses.m2", | |||
| "repository code URI" => "https://github.com/Macaulay2/M2/blob/master/M2/Macaulay2/packages/CharacteristicClasses.m2", | |||
There was a problem hiding this comment.
This key was removed for all certified packages recently, so it shouldn't be re-added
| DebuggingMode => false, | ||
| PackageImports=>{"Elimination","PrimaryDecomposition","Saturation"}, | ||
| Keywords => {"Algebraic Geometry"} |
There was a problem hiding this comment.
The Keywords option shouldn't be removed. It's how packages are sorted in categories on the packages provided with Macaulay2 page.
| Eu:=mutableMatrix(QQ,m,m); | ||
| for b from 1 to m do( | ||
| Zb:=sub(last strata_(m-b),R2); | ||
| if opts.Print==true then <<"big= "<<last strata_(m-b)<<endl; |
There was a problem hiding this comment.
Testing whether a boolean is true using == inside an if statement is redundant. This should just be if opts.Print then ...
This happens in lots of places
There was a problem hiding this comment.
Thanks Doug! I fixed the things you noted and also cleaned up the print options a bit more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added several new methods to the WhitneyStratifications package to compute Whitney stratifications using polar varieties and to compute the Euler characteristic of the complex link and the local Euler obstruction using Whitney stratification.
Added one new method to CharacteristicClasses to compute the Euler characteristic of a complex affine variety.
I forked from M2 development branch.