-
Notifications
You must be signed in to change notification settings - Fork 65
Update python wrappers #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you @Sichao25 . Regarding the pre-processor issue, does the following SO post help? |
Unfortunately, that SO doesn't work on my side. However, I was able to get things working by ignoring the SWIG unrecognized code during compilation and implementing it in another way in the SWIG interface file. (Thanks to Aiden for the idea and resources!) I've added the required template initialization to the PR. I could also implement a similar
But I'm not sure if it's worth the effort, since I feel like it would be relatively straightforward to achieve the same functionality in Python. Do you think it makes sense to skip the |
My opinion is skip |
The changes look good to me and the example is pretty clean. |
…ation realted to macro
@cwsmith Does the comment make sense to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you.
The Python wrappers have been out of date for some time and were only compatible with older versions of PUMI. This PR addresses several related issues:
.smd
file as an alternative to.x_t
to adapt to different versions of Simmetrix.