Skip to content
This repository was archived by the owner on Feb 12, 2021. It is now read-only.

Background image returns 'null' #8

Closed
meendoo opened this issue May 27, 2017 · 7 comments
Closed

Background image returns 'null' #8

meendoo opened this issue May 27, 2017 · 7 comments

Comments

@meendoo
Copy link

meendoo commented May 27, 2017

I noticed that there isn't a fallback image for the background.
The response for that comes as https://image.tmdb.org/t/p/originalnull

To test that I've typed in the movie title Killer: A Journal of Murder (an excellent movie, btw)

Congrats with the project. Looks pretty neat.

@DanWilkes02
Copy link
Contributor

What do you suggest? I've cloned the repo, but I can't see anything looking better than the black screen it does show.

@SKempin
Copy link
Owner

SKempin commented May 30, 2017

@DanWilkes02 Agreed, this is why I haven't created a fallback image for the background. However it would be nice to have a fallback for the poster image.

@DanWilkes02
Copy link
Contributor

I might have a look at it now if your want see what i can do

@DanWilkes02
Copy link
Contributor

I'm done, I'll send over a pull request from my fork in a sec

@meendoo
Copy link
Author

meendoo commented Jun 1, 2017

I thought of a texture (example) applied to the background. In my opinion that works better than a request that fails.

@DanWilkes02
Copy link
Contributor

@meendoo I did consider that but I thought that it might be confusing to a user. It might look like it hasn't loaded instead of there not being an image. I don't know though, it may be a better solution. @SKempin should probably decide what he thinks would work better

@SKempin
Copy link
Owner

SKempin commented Jun 1, 2017

Yes I think it may be confusing. If a background issue is to be used, it would need to denote that no artwork is available.

@SKempin SKempin closed this as completed Jun 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants