Allow adding items to recent search when selecting it from customised plugins

[tchcxp]

Hi team,

Recently I use createLocalStorageRecentSearchesPlugin and createQuerySuggestionsPlugin to build an autocomplete for search. In addition, I made a few customised plugins, mixed with the build-in plugins above.

Everything works perfectly, but I found there is a limit when selecting items from the customised plugins, it will not be added to the local storage recent search.

---

I didn't find much from documents, so I took a further look into the code.

First thing first, there's a typo - should be getDefaultSubscribe.

Then I found the issue is it only adds items from source id querySuggestionsPlugin to recent searches, so it doesn't work on my plugins with a different source id other than querySuggestionsPlugin.

      if (source.sourceId === 'querySuggestionsPlugin' && inputValue) {

I can overwrite the subscribe function, but the problem is there is no way to access its internal store to add an item unless I overwrite the entire storage object.

        store.addItem(recentItem as TItem);

---

My suggestion is to add another param to accept a list of source ids:

export function createRecentSearchesPlugin<TItem extends RecentSearchesItem>({
  storage,
  transformSource = ({ source }) => source,
  subscribe,
  sourceIds, // default to ['querySuggestionsPlugin']
}

and checks whether the current source id is in the list:

      if (sourceIds.includes(source.sourceId) && inputValue) {

Thanks,

[francoischalifour]

Hey! The Recent Searches plugins lets you save item from recentSearchesPlugin.data.addItem(), that you can call in onSelect. You can find an example in this sandbox.

const recentSearchesPlugin = createLocalStorageRecentSearchesPlugin({ /* ... */ });

recentSearchesPlugin.data.addItem({
  id: item.label,
  label: item.label
});

You're right that we forgot to document it in the API ref.