feat: compatibility with React 19 types #1299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #1297
We were relying on the ambient module from
@types/react
which is adevDependency
of the monorepo itself, but since React 19 JSX is no longer global and that made certain files inautocomplete-shared
andautocomplete-js
fail type check.Result
Changed
JSX.Element
toVNode<any>
in the code as it's equivalent :https://github.com/preactjs/preact/blob/4b7e23194bf61ab3764b9d86adb22a4aeafd67ec/src/jsx.d.ts#L63