Skip to content

fix(autocomplete): filter out empty collections in aria-controls #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

mxschmitt
Copy link

@mxschmitt mxschmitt commented Feb 4, 2025

Summary

This PR fixes an issue that the aria-controls value was filled with a reference to empty collections. We can make an assumption to skip them, since recent/favorite collections don't get rendered for 0 size collections. See algolia/docsearch#2485 for more information.

Result

Its covered with tests in algolia/docsearch#2485.

Copy link

codesandbox-ci bot commented Feb 4, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 07b7635:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

@Haroenv Haroenv merged commit d4cca8c into algolia:next Feb 4, 2025
2 checks passed
@Haroenv
Copy link
Contributor

Haroenv commented Feb 4, 2025

Thanks @mxschmitt, will release this soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants