Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: alphagov/accessible-autocomplete
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: alphagov/accessible-autocomplete
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: browser-support
Choose a head ref
  • 7 commits
  • 15 files changed
  • 1 contributor

Commits on Dec 4, 2023

  1. Add .browserslistrc config file

    @colinrotherham
    colinrotherham committed Dec 4, 2023
    Copy the full SHA
    38d5515 View commit details

  2. Update Babel + dependencies 

    From Babel v7.4.0 the `@babel/preset-env` option `corejs: '2'` was implied by default, but it becomes a warning unless added
    @colinrotherham
    colinrotherham committed Dec 4, 2023
    Copy the full SHA
    cfa64f6 View commit details

  3. Use Babel config babel.config.js format

    @colinrotherham
    colinrotherham committed Dec 4, 2023
    Copy the full SHA
    879ea77 View commit details

  4. Apply Babel bug fixes to avoid “catch all” transforms 

    We enable `{ bugfixes: true }` to let Babel use smaller transforms for partially supported browser features

For example, Babel knows that full support for template strings as “tagged templates with escape sequences” only shipped in Safari 11

But we could actually use basic template strings from Safari 9.1+

https://caniuse.com/mdn-javascript_grammar_template_literals_template_literal_revision
    @colinrotherham
    colinrotherham committed Dec 4, 2023
    Copy the full SHA
    e2be5b1 View commit details

  5. Update package core-js for polyfills

    @colinrotherham
    colinrotherham committed Dec 4, 2023
    Copy the full SHA
    b2cd620 View commit details

  6. Match browser config, polyfills, transforms to README 

    Internet Explorer 9–10 support was stopped in:
https://github.com/alphagov/design-system-team-internal/issues/561

This also removes some Babel plugins that stopped IE8 from crashing, but we didn’t support it anyway: #306

The same Browserslist changes were made in:

alphagov/govuk-design-system@bb9b72a
alphagov/govuk-design-system@9969388
    @colinrotherham
    colinrotherham committed Dec 4, 2023
    Copy the full SHA
    0535910 View commit details

  7. Replace package uglifyjs-webpack-plugin with terser-webpack-plugin 

    The UglifyJS webpack plugin was deprecated in December 2019: https://github.com/webpack-contrib/uglifyjs-webpack-plugin

By switching to Terser we can also unblock future upgrades to Node.js 16+ due to OpenSSL changes

https://stackoverflow.com/questions/69692842/error-message-error0308010cdigital-envelope-routinesunsupported
    @colinrotherham
    colinrotherham committed Dec 4, 2023
    Copy the full SHA
    0b28b00 View commit details
Loading