Bypass of spi_axis_reoder IP for Capture Zone 1 and SDI number 2 (ad4630) or 1 (ad4030) #1756

ladace · 2025-06-12T06:58:54Z

PR Description

Removed spi_axis_reorder IP for ad4630 and ad4030 device with one SDI and Capture Zone 1 for Baylibres implementation of driver, this works only for NUM_OF_SDI 2 or 1

PR Type

Bug fix (change that fixes an issue)
New feature (change that adds new functionality)
Breaking change (has dependencies in other repos or will cause CI to fail)
Documentation

PR Checklist

I have followed the code style guidelines
I have performed a self-review of changes
I have compiled all hdl projects and libraries affected by this PR
I have tested in hardware affected projects, at least on relevant boards
I have commented my code, at least hard-to-understand parts
I have signed off all commits from this PR
I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
I have not introduced new Warnings/Critical Warnings on compilation
I have added new hdl testbenches or updated existing ones

ladace · 2025-06-12T08:44:22Z

V0:

Rebase to latest main

ladace · 2025-06-13T11:18:42Z

V1:

Updated READMEs
Added new parameter to optionally remove the spi_axis_reorder IP

ladace · 2025-06-13T12:10:55Z

V2:

Updated documentation

ladace · 2025-06-18T13:25:15Z

V3:

DMA_DATA_WIDTH_SRC different for 1 or 2 SDIs

sarpadi · 2025-07-02T08:58:29Z

Fix conflicts and update READMEs to include the new parameter

sarpadi · 2025-07-03T07:29:17Z

docs/projects/ad4630_fmc/index.rst

@@ -119,6 +119,15 @@ included in the SD card image that is provided with the evaluation board.
   :align: center
   :alt: AD4630_FMC SPI mode - transfer zone 1 block diagram

+For 1 SDI (ad4030) or 2 SDIs (ad4630) a special mode can be build that bypass 


typo - bypasses

sarpadi · 2025-07-03T07:30:04Z

docs/projects/ad4630_fmc/index.rst

+.. image:: ad463x_hdl_cm0_cz1_no_reorder.svg
+   :width: 800
+   :align: center
+   :alt: AD4630_FMC SPI mode - transfer zone 1 block diagram without spi_axis_reorder IP


without USING THE spi_axis_reorder IP

sarpadi · 2025-07-03T07:30:38Z

projects/ad4630_fmc/README.md

for the FPGA carrier THAT you want

ladace · 2025-07-03T08:16:11Z

V4:

Fixed merge conflicts

ladace · 2025-07-03T09:51:04Z

V5:

Fixed remarks

IuliaCMoldovan · 2025-07-04T08:53:31Z

docs/projects/ad4630_fmc/ad463x_hdl_cm0_cz1_no_reorder.svg

Please add the name of this configuration in the block diagram (under the diagram), as well as the name of the evaluation board (on top right corner).

IuliaCMoldovan · 2025-07-04T08:55:03Z

docs/projects/ad4630_fmc/index.rst

+For 1 SDI (ad4030) or 2 SDIs (ad4630) a special mode can be build that bypasses
+the spi_axis_reorder IP and connects the SPI Engine Offload directly to DMA. 
+For other number of SDIs this special mode is not expected to work.


Suggested change

For 1 SDI (ad4030) or 2 SDIs (ad4630) a special mode can be build that bypasses

the spi_axis_reorder IP and connects the SPI Engine Offload directly to DMA.

For other number of SDIs this special mode is not expected to work.

For 1 SDI (:adi:`AD4030`) or 2 SDIs (:adi:`AD4630`) a special mode can be built, that bypasses

the spi_axis_reorder IP and connects the SPI Engine Offload directly to the DMA.

For **other** number of SDIs, this special mode **is not expected to work**.

IuliaCMoldovan · 2025-07-04T08:56:01Z

projects/ad4630_fmc/README.md

-Please enter the folder for the FPGA carrier you want to use and read the README.md.
+Please enter the folder for the FPGA carrier that you want to use and read the README.md.


Please revert this change

Because it is not according to the template, and that phrase is already grammatically correct as it is

IuliaCMoldovan · 2025-07-04T08:56:18Z

projects/ad4630_fmc/common/ad463x_bd.tcl

Update the copyright range

IuliaCMoldovan · 2025-07-04T08:56:58Z

projects/ad4630_fmc/zed/README.md

+NUM_OF_SDI = 1 (ad4030) or NUM_OF_SDI = 2 (ad4630) and directly connects the SPI
+Engine to DMA


Suggested change

NUM_OF_SDI = 1 (ad4030) or NUM_OF_SDI = 2 (ad4630) and directly connects the SPI

Engine to DMA

NUM_OF_SDI = 1 (ad4030) or NUM_OF_SDI = 2 (ad4630) and directly connects the SPI

Engine to DMA

IuliaCMoldovan · 2025-07-04T08:57:46Z

projects/ad4630_fmc/zed/system_bd.tcl

Update the copyright range

IuliaCMoldovan · 2025-07-04T08:57:59Z

projects/ad4630_fmc/zed/system_project.tcl

Update the copyright range

IuliaCMoldovan · 2025-07-04T08:59:24Z

docs/projects/ad4630_fmc/index.rst

You need to add the description of this new parameter in the documentation as well

IuliaCMoldovan · 2025-07-04T09:04:21Z

Can you please update the title of the PR, to be clearer?
As well as the description of the PR, to offer more information.

Remove reorder IP for the mentioned mode and number of SDIs and connected the SPI Engine directly to DMA. This will not work for other modes and number of SDIs. Signed-off-by: Liviu 'Ceshu' Adace <liviu.adace@analog.com>

Signed-off-by: Liviu 'Ceshu' Adace <liviu.adace@analog.com>

Documentation update for the secial case where the spi_axis_reorder IP is bypassed in Capture Zone 1 mode. Signed-off-by: Liviu 'Ceshu' Adace <liviu.adace@analog.com>

ladace · 2025-07-08T08:08:53Z

V6:

Fixed remarks

ladace force-pushed the dev_ad4630_no_reorder branch from 278af3e to 92fafe0 Compare June 12, 2025 08:43

ladace force-pushed the dev_ad4630_no_reorder branch from 92fafe0 to 163149c Compare June 13, 2025 11:16

ladace marked this pull request as ready for review June 13, 2025 12:11

ladace requested review from IuliaCMoldovan, gastmaier, StancaPop, LBFFilho and sarpadi as code owners June 13, 2025 12:11

ladace self-assigned this Jun 13, 2025

ladace force-pushed the dev_ad4630_no_reorder branch from 78ca809 to a8d7821 Compare June 18, 2025 13:20

ladace force-pushed the dev_ad4630_no_reorder branch 2 times, most recently from dd68fb1 to a607fb8 Compare June 18, 2025 13:44

IstvanZsSzekely mentioned this pull request Jun 26, 2025

project: ad463x: New configuration with spi_axi_reorder IP removed analogdevicesinc/testbenches#239

Merged

13 tasks

sarpadi reviewed Jul 3, 2025

View reviewed changes

ladace force-pushed the dev_ad4630_no_reorder branch from a607fb8 to f6c0d23 Compare July 3, 2025 08:14

ladace force-pushed the dev_ad4630_no_reorder branch from f6c0d23 to e9b7984 Compare July 3, 2025 09:50

ladace requested a review from sarpadi July 3, 2025 09:51

PIoandan previously approved these changes Jul 4, 2025

View reviewed changes

IuliaCMoldovan requested changes Jul 4, 2025

View reviewed changes

ladace added 3 commits July 8, 2025 10:37

projects: ad4628_fmc: Remove reorder IP for SDI 1 or 2 and CZ 1

0fa3995

Remove reorder IP for the mentioned mode and number of SDIs and connected the SPI Engine directly to DMA. This will not work for other modes and number of SDIs. Signed-off-by: Liviu 'Ceshu' Adace <liviu.adace@analog.com>

projects: ad4630_fmc: README: Updated READMEs

314409d

Signed-off-by: Liviu 'Ceshu' Adace <liviu.adace@analog.com>

docs: ad4630_fmc: Update documentation

88fe8f1

Documentation update for the secial case where the spi_axis_reorder IP is bypassed in Capture Zone 1 mode. Signed-off-by: Liviu 'Ceshu' Adace <liviu.adace@analog.com>

ladace dismissed PIoandan’s stale review via 88fe8f1 July 8, 2025 08:08

ladace force-pushed the dev_ad4630_no_reorder branch from e9b7984 to 88fe8f1 Compare July 8, 2025 08:08

ladace changed the title ~~Dev ad4630 no reorder~~ ad4630 (ad4030) bypass of spi_axis_reoder IP for Capture Zone 1 and SDI number 2 (ad4630) or 1 (ad4030) Jul 8, 2025

ladace requested review from IuliaCMoldovan and PIoandan July 8, 2025 08:14

ladace changed the title ~~ad4630 (ad4030) bypass of spi_axis_reoder IP for Capture Zone 1 and SDI number 2 (ad4630) or 1 (ad4030)~~ Bypass of spi_axis_reoder IP for Capture Zone 1 and SDI number 2 (ad4630) or 1 (ad4030) Jul 8, 2025

		Please enter the folder for the FPGA carrier you want to use and read the README.md. No newline at end of file
		Please enter the folder for the FPGA carrier that you want to use and read the README.md.

		NUM_OF_SDI = 1 (ad4030) or NUM_OF_SDI = 2 (ad4630) and directly connects the SPI
		Engine to DMA

Bypass of spi_axis_reoder IP for Capture Zone 1 and SDI number 2 (ad4630) or 1 (ad4030) #1756

Are you sure you want to change the base?

Bypass of spi_axis_reoder IP for Capture Zone 1 and SDI number 2 (ad4630) or 1 (ad4030) #1756

Uh oh!

Conversation

ladace commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Description

PR Type

PR Checklist

Uh oh!

ladace commented Jun 12, 2025

Uh oh!

ladace commented Jun 13, 2025

Uh oh!

ladace commented Jun 13, 2025

Uh oh!

ladace commented Jun 18, 2025

Uh oh!

sarpadi commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ladace commented Jul 3, 2025

Uh oh!

ladace commented Jul 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IuliaCMoldovan commented Jul 4, 2025

Uh oh!

ladace commented Jul 8, 2025

Uh oh!

Uh oh!

ladace commented Jun 12, 2025 •

edited

Loading

sarpadi commented Jul 2, 2025 •

edited

Loading