Skip to content

chore: move udf registration to better place #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rluvaton
Copy link
Contributor

Which issue does this PR close?

N/A

Rationale for this change

Some registration exists in the prepare_datafusion_session_context and some in the PhysicalPlanner::new, moved to a single place - prepare_datafusion_session_context

What changes are included in this PR?

  1. Move SparkExpm1 udf registration to prepare_datafusion_session_context
  2. Move all Comet Spark UDFs like SparkBitwiseNot, SparkBitwiseCount, etc to register in register_all_comet_functions inside the spark-expr crate

How are these changes tested?

Existing tests

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.90%. Comparing base (f09f8af) to head (9bc7e05).
Report is 266 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1899      +/-   ##
============================================
+ Coverage     56.12%   58.90%   +2.77%     
- Complexity      976     1149     +173     
============================================
  Files           119      130      +11     
  Lines         11743    12827    +1084     
  Branches       2251     2413     +162     
============================================
+ Hits           6591     7556     +965     
- Misses         4012     4048      +36     
- Partials       1140     1223      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants