chore: move udf registration to better place #1899
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Some registration exists in the
prepare_datafusion_session_context
and some in thePhysicalPlanner::new
, moved to a single place -prepare_datafusion_session_context
What changes are included in this PR?
SparkExpm1
udf registration toprepare_datafusion_session_context
SparkBitwiseNot
,SparkBitwiseCount
, etc to register inregister_all_comet_functions
inside thespark-expr
crateHow are these changes tested?
Existing tests