Skip to content

branch-3.1: [fix](nereids) fix sum0 cannot pass multi distinct check #51234 #52080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

branch-3.1: [fix](nereids) fix sum0 cannot pass multi distinct check #51234 #52080

merged 1 commit into from
Jun 23, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #51234

@feiniaofeiafei
[fix](nereids) fix sum0 cannot pass multi distinct check (#51234)
f22cdd9 
### What problem does this PR solve?

Related PR: #32541

Problem Summary:
Before this pr, execute below sql will report error: sum0(DISTINCT c#2) can't support multi distinct.
This pr change the check, and the sql can be executed. sql is:
select sum0(distinct b),sum(distinct c) from test_sum0_multi_distinct_with_group_by group by a
@github-actions github-actions bot requested a review from morrySnow as a code owner June 20, 2025 12:08
@Thearas
Copy link
Contributor

Thearas commented Jun 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jun 20, 2025
@Thearas
Copy link
Contributor

Thearas commented Jun 20, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40122 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f22cdd949e54d6715c95934e314982f1280b195d, data reload: false

------ Round 1 ----------------------------------
q1	17589	6805	6653	6653
q2	2076	164	162	162
q3	10565	1150	1165	1150
q4	10223	749	728	728
q5	7744	2913	2823	2823
q6	214	133	133	133
q7	973	619	598	598
q8	9353	1942	2030	1942
q9	6685	6400	6436	6400
q10	7015	2304	2307	2304
q11	468	257	270	257
q12	396	212	209	209
q13	17765	2982	2992	2982
q14	237	209	212	209
q15	493	465	460	460
q16	441	382	373	373
q17	973	572	592	572
q18	7350	6760	6771	6760
q19	1319	1037	1046	1037
q20	503	198	198	198
q21	4156	3155	3178	3155
q22	1119	1027	1017	1017
Total cold run time: 107657 ms
Total hot run time: 40122 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6573	6616	6573	6573
q2	325	239	233	233
q3	2877	2763	2860	2763
q4	2062	1836	1813	1813
q5	5682	5734	5734	5734
q6	205	125	125	125
q7	2180	1786	1816	1786
q8	3332	3511	3481	3481
q9	8871	8767	8843	8767
q10	3587	3535	3541	3535
q11	602	498	509	498
q12	807	622	607	607
q13	13193	3167	3115	3115
q14	316	267	255	255
q15	510	474	463	463
q16	481	448	425	425
q17	1818	1632	1619	1619
q18	8202	7596	7734	7596
q19	1690	1560	1631	1560
q20	2066	1905	1903	1903
q21	5285	4797	4894	4797
q22	1111	1035	993	993
Total cold run time: 71775 ms
Total hot run time: 58641 ms

@morrySnow morrySnow merged commit 6c8ad0f into branch-3.1 Jun 23, 2025
20 of 23 checks passed
@morrySnow morrySnow deleted the auto-pick-51234-branch-3.1 branch June 23, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Thearas @doris-robot @morrySnow @dataroaring @feiniaofeiafei