Skip to content

branch-3.1: [refactor](nereids)move PhysicalWindow child request property deriving from LogicalWindowToPhysicalWindow to RequestPropertyDeriver #50891 #52081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

branch-3.1: [refactor](nereids)move PhysicalWindow child request property deriving from LogicalWindowToPhysicalWindow to RequestPropertyDeriver #50891 #52081

merged 1 commit into from
Jun 23, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 20, 2025

Cherry-picked from #50891

@feiniaofeiafei
[refactor](nereids)move PhysicalWindow child request property derivin…
b018df7 
…g from LogicalWindowToPhysicalWindow to RequestPropertyDeriver (#50891)

…wToPhysicalWindow to RequestPropertyDeriver

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [x] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot requested a review from morrySnow as a code owner June 20, 2025 12:09
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jun 20, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 20, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 20, 2025

TPC-H: Total hot run time: 40207 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b018df72f2a5b7e7a76ba946b5055bcb5e22a512, data reload: false

------ Round 1 ----------------------------------
q1	17598	7625	6743	6743
q2	2064	169	186	169
q3	10618	1165	1208	1165
q4	10272	743	725	725
q5	7775	2918	2856	2856
q6	222	140	138	138
q7	993	620	613	613
q8	9368	2024	2075	2024
q9	6800	6894	6446	6446
q10	7056	2270	2309	2270
q11	461	269	258	258
q12	455	215	218	215
q13	17807	3052	2995	2995
q14	233	212	222	212
q15	504	460	471	460
q16	483	389	390	389
q17	1007	662	601	601
q18	7347	6657	6793	6657
q19	1325	1002	927	927
q20	512	205	202	202
q21	4125	3290	3150	3150
q22	1107	1005	992	992
Total cold run time: 108132 ms
Total hot run time: 40207 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6598	6552	6610	6552
q2	339	242	236	236
q3	2955	2813	2802	2802
q4	1982	1716	1741	1716
q5	5473	5482	5472	5472
q6	208	125	130	125
q7	2102	1698	1735	1698
q8	3303	3460	3471	3460
q9	8623	8651	8546	8546
q10	3490	3447	3468	3447
q11	586	495	473	473
q12	760	600	587	587
q13	9216	3042	2981	2981
q14	287	265	272	265
q15	493	458	457	457
q16	469	417	419	417
q17	1827	1607	1540	1540
q18	7764	7554	7344	7344
q19	1682	1530	1577	1530
q20	2047	1821	1808	1808
q21	5207	4870	4894	4870
q22	1134	997	982	982
Total cold run time: 66545 ms
Total hot run time: 57308 ms

@doris-robot
Copy link

doris-robot commented Jun 20, 2025

TPC-DS: Total hot run time: 190107 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b018df72f2a5b7e7a76ba946b5055bcb5e22a512, data reload: false

query1	986	387	382	382
query2	5647	1962	1907	1907
query3	6649	219	223	219
query4	33145	23498	23694	23498
query5	4336	463	471	463
query6	279	181	197	181
query7	4627	324	319	319
query8	288	224	231	224
query9	9690	2573	2561	2561
query10	490	274	252	252
query11	18612	15275	15327	15275
query12	156	104	103	103
query13	1645	430	411	411
query14	10053	6612	6732	6612
query15	230	170	181	170
query16	7490	493	484	484
query17	1605	591	567	567
query18	1967	300	298	298
query19	291	149	149	149
query20	117	107	109	107
query21	204	104	101	101
query22	4526	4117	4252	4117
query23	33873	33263	33147	33147
query24	11101	2896	2859	2859
query25	554	383	388	383
query26	1114	167	168	167
query27	2965	341	334	334
query28	7801	2087	2088	2087
query29	788	425	423	423
query30	313	164	153	153
query31	1020	795	797	795
query32	73	61	60	60
query33	747	295	292	292
query34	906	500	504	500
query35	827	735	695	695
query36	1081	946	986	946
query37	128	68	68	68
query38	3961	3834	3899	3834
query39	1482	1441	1434	1434
query40	270	101	97	97
query41	50	45	47	45
query42	113	99	98	98
query43	559	484	479	479
query44	1245	784	786	784
query45	185	172	171	171
query46	1161	721	730	721
query47	1892	1806	1872	1806
query48	439	333	347	333
query49	1185	412	392	392
query50	826	434	413	413
query51	7319	7131	7056	7056
query52	100	87	92	87
query53	250	184	182	182
query54	1123	463	467	463
query55	79	81	83	81
query56	282	258	249	249
query57	1272	1181	1152	1152
query58	241	212	217	212
query59	3183	3046	2892	2892
query60	292	271	277	271
query61	140	140	136	136
query62	876	686	669	669
query63	228	200	193	193
query64	3655	733	740	733
query65	3413	3212	3212	3212
query66	1201	323	316	316
query67	15953	15508	15615	15508
query68	4715	578	563	563
query69	458	295	276	276
query70	1184	1089	1110	1089
query71	416	284	254	254
query72	6189	4131	4212	4131
query73	761	353	350	350
query74	10514	9157	9260	9157
query75	3400	2652	2617	2617
query76	2332	1067	1039	1039
query77	382	281	274	274
query78	10539	9671	9689	9671
query79	1474	582	583	582
query80	860	434	433	433
query81	541	221	222	221
query82	968	94	88	88
query83	226	146	153	146
query84	241	85	79	79
query85	1262	310	302	302
query86	374	293	282	282
query87	4394	4261	4256	4256
query88	3657	2390	2369	2369
query89	414	292	287	287
query90	1937	189	190	189
query91	150	106	109	106
query92	59	53	54	53
query93	1080	555	543	543
query94	875	289	304	289
query95	354	262	260	260
query96	611	281	281	281
query97	3340	3146	3104	3104
query98	219	199	200	199
query99	1505	1318	1289	1289
Total cold run time: 294730 ms
Total hot run time: 190107 ms

@doris-robot
Copy link

doris-robot commented Jun 20, 2025

ClickBench: Total hot run time: 30.58 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b018df72f2a5b7e7a76ba946b5055bcb5e22a512, data reload: false

query1	0.04	0.02	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.63	0.10	0.10
query5	0.51	0.50	0.51
query6	1.13	0.73	0.74
query7	0.02	0.02	0.01
query8	0.04	0.05	0.04
query9	0.56	0.50	0.49
query10	0.55	0.54	0.55
query11	0.15	0.10	0.11
query12	0.15	0.11	0.11
query13	0.61	0.59	0.59
query14	0.78	0.80	0.79
query15	0.84	0.82	0.82
query16	0.39	0.38	0.37
query17	1.08	1.03	1.07
query18	0.23	0.22	0.22
query19	1.91	1.80	1.82
query20	0.02	0.01	0.01
query21	15.38	0.60	0.59
query22	2.20	1.88	1.88
query23	17.11	0.86	0.92
query24	3.01	1.21	1.04
query25	0.11	0.20	0.19
query26	0.47	0.14	0.15
query27	0.04	0.04	0.04
query28	10.28	0.51	0.50
query29	12.58	3.25	3.23
query30	0.24	0.06	0.06
query31	2.85	0.40	0.38
query32	3.23	0.47	0.46
query33	2.98	3.00	3.06
query34	16.92	4.52	4.55
query35	4.58	4.56	4.55
query36	0.65	0.48	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.02	0.03
Total cold run time: 104.07 s
Total hot run time: 30.58 s

@morrySnow morrySnow merged commit 0829457 into branch-3.1 Jun 23, 2025
22 checks passed
@morrySnow morrySnow deleted the auto-pick-50891-branch-3.1 branch June 23, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @doris-robot @morrySnow @dataroaring @feiniaofeiafei