Skip to content

[fix](nereids) fix tanh cosntant folding #52100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 30, 2025
Merged

[fix](nereids) fix tanh cosntant folding #52100

merged 4 commits into from
Jun 30, 2025

Conversation

@wumeibanfa
Copy link
Contributor

@wumeibanfa wumeibanfa commented Jun 21, 2025 •
edited
Loading

What problem does this PR solve?

fix tanh @ExecFunction(name)

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

change @ExecFunction(name=cosh) to @ExecFunction(name=tanh)

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jun 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wumeibanfa
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33949 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ccbd97b172f3a870bd8ecb962c604e705a04fef2, data reload: false

------ Round 1 ----------------------------------
q1	17576	5087	4954	4954
q2	1938	285	183	183
q3	10350	1308	746	746
q4	10286	1033	523	523
q5	8586	2379	2362	2362
q6	188	169	129	129
q7	903	733	586	586
q8	9293	1306	1062	1062
q9	6844	5093	5104	5093
q10	6868	2400	1945	1945
q11	474	290	268	268
q12	343	349	212	212
q13	17793	3625	3045	3045
q14	237	239	217	217
q15	566	472	480	472
q16	433	426	387	387
q17	615	846	399	399
q18	7611	7204	7190	7190
q19	1401	944	545	545
q20	339	339	226	226
q21	4090	3134	2391	2391
q22	1040	1018	1014	1014
Total cold run time: 107774 ms
Total hot run time: 33949 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5078	5061	5062	5061
q2	257	316	223	223
q3	2155	2694	2307	2307
q4	1361	1806	1321	1321
q5	4201	4105	4369	4105
q6	252	169	126	126
q7	2032	1936	1749	1749
q8	2578	2620	2541	2541
q9	7224	7189	7063	7063
q10	3029	3235	2824	2824
q11	580	510	493	493
q12	686	768	609	609
q13	3422	3857	3235	3235
q14	283	301	263	263
q15	523	470	470	470
q16	448	473	434	434
q17	1165	1502	1365	1365
q18	7668	7449	7379	7379
q19	794	987	944	944
q20	1971	2053	1948	1948
q21	4982	4447	4406	4406
q22	1039	1022	959	959
Total cold run time: 51728 ms
Total hot run time: 49825 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184793 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ccbd97b172f3a870bd8ecb962c604e705a04fef2, data reload: false

query1	1001	390	400	390
query2	6529	1804	1755	1755
query3	6745	221	218	218
query4	26117	23347	22919	22919
query5	4339	616	466	466
query6	299	215	204	204
query7	4629	491	289	289
query8	269	244	209	209
query9	8649	2606	2641	2606
query10	482	349	266	266
query11	15714	15363	14711	14711
query12	162	109	105	105
query13	1669	534	418	418
query14	9550	6104	6022	6022
query15	207	198	180	180
query16	7310	622	473	473
query17	1200	732	595	595
query18	1995	409	311	311
query19	209	199	157	157
query20	123	114	118	114
query21	218	129	115	115
query22	4305	4250	4127	4127
query23	34040	33186	33012	33012
query24	8480	2369	2361	2361
query25	547	458	401	401
query26	1238	269	152	152
query27	2759	516	345	345
query28	4279	2144	2097	2097
query29	780	535	440	440
query30	288	216	190	190
query31	948	829	764	764
query32	75	68	59	59
query33	550	368	332	332
query34	786	844	538	538
query35	781	823	740	740
query36	968	965	873	873
query37	114	100	75	75
query38	4093	4140	4055	4055
query39	1458	1422	1398	1398
query40	217	137	107	107
query41	67	59	59	59
query42	127	106	112	106
query43	488	501	460	460
query44	1289	829	831	829
query45	178	167	160	160
query46	839	1013	631	631
query47	1782	1823	1736	1736
query48	391	421	318	318
query49	752	472	404	404
query50	639	691	413	413
query51	4151	4159	4123	4123
query52	117	108	98	98
query53	223	252	186	186
query54	574	576	503	503
query55	90	85	84	84
query56	308	305	272	272
query57	1171	1208	1144	1144
query58	263	252	274	252
query59	2530	2633	2542	2542
query60	331	321	304	304
query61	125	123	123	123
query62	811	712	661	661
query63	236	184	184	184
query64	4380	989	673	673
query65	4260	4132	4147	4132
query66	1128	414	387	387
query67	15792	15835	15307	15307
query68	8362	896	534	534
query69	472	300	277	277
query70	1155	1125	1092	1092
query71	474	325	309	309
query72	5304	4698	4608	4608
query73	683	567	358	358
query74	8908	9125	8650	8650
query75	3824	3167	2685	2685
query76	3689	1198	734	734
query77	774	377	300	300
query78	10008	10174	9467	9467
query79	1909	818	590	590
query80	595	507	446	446
query81	470	257	222	222
query82	435	132	96	96
query83	251	262	229	229
query84	244	108	87	87
query85	786	363	343	343
query86	342	305	340	305
query87	4393	4465	4353	4353
query88	3332	2236	2221	2221
query89	382	310	290	290
query90	1953	210	199	199
query91	140	140	114	114
query92	75	63	60	60
query93	1486	938	592	592
query94	676	422	354	354
query95	373	296	275	275
query96	493	567	277	277
query97	2725	2753	2594	2594
query98	236	208	200	200
query99	1417	1390	1252	1252
Total cold run time: 273530 ms
Total hot run time: 184793 ms

@wumeibanfa
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33713 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ccbd97b172f3a870bd8ecb962c604e705a04fef2, data reload: false

------ Round 1 ----------------------------------
q1	17666	5112	4990	4990
q2	1931	284	192	192
q3	10306	1265	698	698
q4	10213	1016	516	516
q5	7522	2399	2296	2296
q6	186	163	132	132
q7	912	717	596	596
q8	9301	1251	1113	1113
q9	6694	5006	5092	5006
q10	6881	2361	1948	1948
q11	463	281	277	277
q12	336	345	210	210
q13	17767	3634	3123	3123
q14	229	230	237	230
q15	567	477	479	477
q16	430	420	369	369
q17	580	841	359	359
q18	7511	7212	7148	7148
q19	1864	941	524	524
q20	321	328	225	225
q21	3620	2610	2309	2309
q22	1105	1023	975	975
Total cold run time: 106405 ms
Total hot run time: 33713 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5185	5064	5085	5064
q2	238	326	224	224
q3	2183	2621	2308	2308
q4	1321	1754	1383	1383
q5	4210	4313	4394	4313
q6	215	174	134	134
q7	2058	1885	1808	1808
q8	2581	2572	2537	2537
q9	7100	7065	7108	7065
q10	3139	3284	2824	2824
q11	575	517	504	504
q12	672	815	618	618
q13	3491	3909	3329	3329
q14	276	313	264	264
q15	526	480	482	480
q16	444	504	440	440
q17	1122	1516	1309	1309
q18	7270	7187	7066	7066
q19	754	777	1001	777
q20	1895	1950	1862	1862
q21	4734	4406	4460	4406
q22	1096	1022	965	965
Total cold run time: 51085 ms
Total hot run time: 49680 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184974 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ccbd97b172f3a870bd8ecb962c604e705a04fef2, data reload: false

query1	993	390	397	390
query2	6525	1833	1822	1822
query3	6737	212	210	210
query4	26329	23376	23189	23189
query5	4352	606	442	442
query6	322	209	201	201
query7	4616	480	284	284
query8	270	223	216	216
query9	8640	2649	2665	2649
query10	493	345	299	299
query11	15291	15048	14892	14892
query12	163	117	108	108
query13	1657	522	419	419
query14	9305	6106	6087	6087
query15	202	190	178	178
query16	7439	644	487	487
query17	1181	707	554	554
query18	1986	403	295	295
query19	188	184	180	180
query20	118	113	118	113
query21	217	123	108	108
query22	4173	4227	4056	4056
query23	33730	32860	33072	32860
query24	8416	2344	2373	2344
query25	528	460	391	391
query26	1204	265	147	147
query27	2760	503	348	348
query28	4346	2126	2130	2126
query29	740	537	439	439
query30	286	221	199	199
query31	947	813	763	763
query32	70	69	61	61
query33	548	360	296	296
query34	777	837	524	524
query35	777	824	740	740
query36	957	972	888	888
query37	109	103	87	87
query38	4057	4131	4062	4062
query39	1537	1426	1577	1426
query40	225	123	112	112
query41	72	66	73	66
query42	128	114	111	111
query43	516	496	477	477
query44	1285	813	825	813
query45	193	178	176	176
query46	862	1024	638	638
query47	1761	1814	1750	1750
query48	394	430	318	318
query49	763	505	385	385
query50	621	685	399	399
query51	4073	4082	4176	4082
query52	115	112	100	100
query53	221	249	185	185
query54	565	564	498	498
query55	92	82	84	82
query56	307	299	292	292
query57	1211	1194	1132	1132
query58	269	257	252	252
query59	2655	2635	2573	2573
query60	330	343	299	299
query61	130	126	133	126
query62	805	705	647	647
query63	223	187	186	186
query64	4289	1039	672	672
query65	4263	4171	4165	4165
query66	1105	401	320	320
query67	15697	15554	15310	15310
query68	8007	882	524	524
query69	465	300	273	273
query70	1218	1151	1183	1151
query71	470	308	299	299
query72	5655	4650	4711	4650
query73	684	609	348	348
query74	8826	9077	8702	8702
query75	3847	3192	2657	2657
query76	3634	1194	784	784
query77	808	387	286	286
query78	10029	10202	9231	9231
query79	2222	875	582	582
query80	582	505	444	444
query81	491	273	227	227
query82	500	129	98	98
query83	258	250	232	232
query84	248	99	87	87
query85	822	354	313	313
query86	388	309	295	295
query87	4351	4487	4315	4315
query88	3772	2269	2231	2231
query89	374	319	283	283
query90	1886	208	207	207
query91	140	141	110	110
query92	79	62	58	58
query93	1739	949	579	579
query94	712	415	306	306
query95	375	293	287	287
query96	500	567	277	277
query97	2769	2740	2607	2607
query98	235	232	210	210
query99	1329	1385	1275	1275
Total cold run time: 273571 ms
Total hot run time: 184974 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.99 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ccbd97b172f3a870bd8ecb962c604e705a04fef2, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.07
query4	1.62	0.11	0.10
query5	0.44	0.42	0.41
query6	1.16	0.66	0.66
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.59	0.53	0.52
query10	0.57	0.57	0.57
query11	0.16	0.10	0.12
query12	0.15	0.11	0.12
query13	0.63	0.60	0.62
query14	0.81	0.80	0.80
query15	0.89	0.87	0.86
query16	0.40	0.39	0.40
query17	1.09	1.06	1.05
query18	0.23	0.22	0.22
query19	1.98	1.89	1.82
query20	0.01	0.01	0.01
query21	15.37	0.93	0.56
query22	0.77	1.20	0.63
query23	14.95	1.38	0.59
query24	6.76	1.43	1.22
query25	0.49	0.11	0.14
query26	0.66	0.15	0.15
query27	0.06	0.05	0.06
query28	10.00	0.86	0.44
query29	12.54	3.92	3.36
query30	0.25	0.09	0.07
query31	2.83	0.60	0.39
query32	3.23	0.56	0.47
query33	3.05	3.06	3.09
query34	16.11	5.43	4.84
query35	4.86	4.86	4.85
query36	0.70	0.51	0.49
query37	0.09	0.06	0.07
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.14
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 104.24 s
Total hot run time: 29.99 s

@wumeibanfa
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33997 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4713b2c477eeeb60657d5883f38610475d16c8ab, data reload: false

------ Round 1 ----------------------------------
q1	17601	5262	5063	5063
q2	1964	297	195	195
q3	10247	1336	731	731
q4	10225	1025	538	538
q5	7518	2360	2389	2360
q6	181	170	139	139
q7	884	751	602	602
q8	9318	1307	1144	1144
q9	6784	5049	5124	5049
q10	6909	2443	1975	1975
q11	494	301	292	292
q12	354	360	220	220
q13	17746	3682	3080	3080
q14	232	226	222	222
q15	543	484	470	470
q16	437	444	374	374
q17	577	871	352	352
q18	7635	7239	7026	7026
q19	1220	934	552	552
q20	346	339	217	217
q21	3850	3194	2417	2417
q22	1059	1043	979	979
Total cold run time: 106124 ms
Total hot run time: 33997 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5130	5072	5126	5072
q2	250	318	220	220
q3	2201	2727	2317	2317
q4	1371	1784	1342	1342
q5	4486	4470	4486	4470
q6	219	173	126	126
q7	2018	1931	1737	1737
q8	2646	2620	2478	2478
q9	7172	7141	7199	7141
q10	3092	3251	2818	2818
q11	591	526	500	500
q12	679	775	614	614
q13	3628	3984	3315	3315
q14	292	312	273	273
q15	523	477	471	471
q16	460	493	448	448
q17	1166	1583	1339	1339
q18	7731	7454	7366	7366
q19	831	793	841	793
q20	1986	2060	1946	1946
q21	4983	4506	4343	4343
q22	1062	1006	956	956
Total cold run time: 52517 ms
Total hot run time: 50085 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186764 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4713b2c477eeeb60657d5883f38610475d16c8ab, data reload: false

query1	1003	407	394	394
query2	6532	1841	1824	1824
query3	6760	218	234	218
query4	26428	23432	23635	23432
query5	4295	640	492	492
query6	309	215	216	215
query7	4626	510	301	301
query8	292	233	232	232
query9	8618	2644	2660	2644
query10	472	342	273	273
query11	16018	15499	15036	15036
query12	172	107	102	102
query13	1675	538	401	401
query14	9484	6046	6083	6046
query15	212	199	185	185
query16	7231	625	458	458
query17	1173	721	574	574
query18	1975	405	298	298
query19	209	188	156	156
query20	151	121	115	115
query21	216	136	110	110
query22	4117	4111	4096	4096
query23	33946	33152	33149	33149
query24	8494	2410	2380	2380
query25	542	465	391	391
query26	1233	270	158	158
query27	2762	524	346	346
query28	4332	2130	2119	2119
query29	794	557	443	443
query30	283	216	206	206
query31	940	831	755	755
query32	75	72	61	61
query33	561	368	297	297
query34	796	848	552	552
query35	791	834	748	748
query36	944	991	875	875
query37	121	103	82	82
query38	4298	4254	4110	4110
query39	1470	1445	1433	1433
query40	219	130	120	120
query41	73	67	67	67
query42	132	121	151	121
query43	488	496	506	496
query44	1339	813	810	810
query45	182	182	173	173
query46	867	1053	641	641
query47	1745	1791	1714	1714
query48	393	428	308	308
query49	764	525	419	419
query50	648	696	419	419
query51	4159	4157	4156	4156
query52	118	113	101	101
query53	231	266	184	184
query54	588	587	506	506
query55	83	83	89	83
query56	309	313	292	292
query57	1211	1170	1123	1123
query58	277	284	267	267
query59	2682	2612	2598	2598
query60	323	339	314	314
query61	129	128	135	128
query62	804	732	649	649
query63	249	198	198	198
query64	4401	1007	690	690
query65	4270	4264	4183	4183
query66	1148	431	337	337
query67	15918	15583	15640	15583
query68	6431	920	537	537
query69	497	325	283	283
query70	1215	1119	1097	1097
query71	413	337	321	321
query72	5660	4941	4679	4679
query73	660	596	349	349
query74	9191	8838	8918	8838
query75	3190	3233	2725	2725
query76	3233	1216	808	808
query77	490	397	300	300
query78	10154	10255	9336	9336
query79	2665	855	586	586
query80	652	518	449	449
query81	501	263	224	224
query82	491	134	100	100
query83	256	371	239	239
query84	248	107	87	87
query85	835	363	323	323
query86	386	304	284	284
query87	4489	4571	4285	4285
query88	3895	2252	2278	2252
query89	382	310	289	289
query90	1930	210	205	205
query91	141	138	113	113
query92	78	64	62	62
query93	2441	980	578	578
query94	686	420	304	304
query95	378	296	289	289
query96	501	579	281	281
query97	2742	2793	2682	2682
query98	236	213	256	213
query99	1377	1400	1259	1259
Total cold run time: 274544 ms
Total hot run time: 186764 ms

@wumeibanfa
Copy link
Contributor Author

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 33912 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4713b2c477eeeb60657d5883f38610475d16c8ab, data reload: false

------ Round 1 ----------------------------------
q1	17599	5178	5061	5061
q2	1941	278	188	188
q3	10506	1242	728	728
q4	10307	1001	519	519
q5	9045	2338	2371	2338
q6	205	157	131	131
q7	878	754	608	608
q8	9328	1217	1002	1002
q9	6880	5114	5086	5086
q10	6875	2365	1999	1999
q11	476	288	305	288
q12	345	343	221	221
q13	17760	3668	3071	3071
q14	223	233	210	210
q15	558	465	472	465
q16	412	434	364	364
q17	592	843	364	364
q18	7498	7270	7199	7199
q19	1579	972	542	542
q20	313	330	218	218
q21	3640	2561	2349	2349
q22	1072	1036	961	961
Total cold run time: 108032 ms
Total hot run time: 33912 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5140	5047	5075	5047
q2	237	329	215	215
q3	2158	2657	2320	2320
q4	1361	1777	1376	1376
q5	4233	4347	4402	4347
q6	212	166	126	126
q7	1965	1933	1786	1786
q8	2563	2557	2453	2453
q9	7110	7209	7113	7113
q10	3081	3231	2848	2848
q11	570	544	501	501
q12	713	773	597	597
q13	3557	3887	3240	3240
q14	299	303	292	292
q15	513	492	479	479
q16	429	482	427	427
q17	1126	1506	1310	1310
q18	7311	7255	7151	7151
q19	773	833	868	833
q20	1907	2034	1852	1852
q21	4667	4218	4312	4218
q22	1071	1028	1013	1013
Total cold run time: 50996 ms
Total hot run time: 49544 ms

@wumeibanfa
Copy link
Contributor Author

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 33772 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4713b2c477eeeb60657d5883f38610475d16c8ab, data reload: false

------ Round 1 ----------------------------------
q1	17620	5159	5033	5033
q2	1942	275	181	181
q3	10321	1273	696	696
q4	10218	1016	506	506
q5	7508	2315	2298	2298
q6	176	159	129	129
q7	867	734	617	617
q8	9301	1456	1026	1026
q9	6997	5117	5102	5102
q10	6866	2418	1959	1959
q11	494	307	266	266
q12	339	354	218	218
q13	17767	3643	3071	3071
q14	230	229	222	222
q15	536	480	472	472
q16	416	425	393	393
q17	598	834	352	352
q18	7647	7243	7078	7078
q19	1224	946	543	543
q20	332	353	226	226
q21	4006	3212	2403	2403
q22	1021	999	981	981
Total cold run time: 106426 ms
Total hot run time: 33772 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5141	5114	5134	5114
q2	235	323	230	230
q3	2159	2637	2296	2296
q4	1407	1814	1373	1373
q5	4196	4370	4505	4370
q6	216	165	123	123
q7	1994	1907	1776	1776
q8	2571	2582	2544	2544
q9	7163	7153	7074	7074
q10	3083	3242	2882	2882
q11	570	514	502	502
q12	657	752	612	612
q13	3503	3913	3318	3318
q14	273	319	286	286
q15	528	482	481	481
q16	432	508	442	442
q17	1158	1521	1384	1384
q18	7672	7561	7391	7391
q19	775	769	931	769
q20	1968	2021	1886	1886
q21	4963	4465	4244	4244
q22	1115	1034	1008	1008
Total cold run time: 51779 ms
Total hot run time: 50105 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184431 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4713b2c477eeeb60657d5883f38610475d16c8ab, data reload: false

query1	1026	398	382	382
query2	6526	1739	1758	1739
query3	6740	208	220	208
query4	26665	23569	22968	22968
query5	4339	567	453	453
query6	333	208	196	196
query7	4624	489	288	288
query8	271	214	205	205
query9	8593	2629	2642	2629
query10	483	312	302	302
query11	15344	15355	14772	14772
query12	156	109	101	101
query13	1639	525	397	397
query14	8598	5662	5613	5613
query15	204	202	166	166
query16	7127	645	448	448
query17	961	741	590	590
query18	1983	406	315	315
query19	195	191	166	166
query20	121	135	120	120
query21	209	127	110	110
query22	4191	4204	4106	4106
query23	34530	33167	33012	33012
query24	8420	2365	2386	2365
query25	550	467	393	393
query26	1238	268	145	145
query27	2766	509	344	344
query28	4341	2153	2118	2118
query29	792	554	433	433
query30	278	218	193	193
query31	920	801	740	740
query32	72	74	67	67
query33	563	385	321	321
query34	799	843	542	542
query35	801	823	728	728
query36	940	969	901	901
query37	118	104	74	74
query38	4165	4225	4067	4067
query39	1461	1414	1420	1414
query40	216	113	106	106
query41	53	52	53	52
query42	125	108	105	105
query43	506	501	493	493
query44	1308	839	827	827
query45	178	165	156	156
query46	828	1024	629	629
query47	1763	1818	1724	1724
query48	377	419	313	313
query49	764	484	390	390
query50	632	689	406	406
query51	4121	4153	4120	4120
query52	116	110	95	95
query53	221	258	186	186
query54	564	563	503	503
query55	83	78	81	78
query56	290	289	287	287
query57	1212	1200	1136	1136
query58	266	247	252	247
query59	2664	2775	2540	2540
query60	327	304	307	304
query61	126	120	116	116
query62	828	703	656	656
query63	228	189	193	189
query64	4359	1020	642	642
query65	4254	4199	4179	4179
query66	1160	414	357	357
query67	15856	15718	15384	15384
query68	8368	909	532	532
query69	464	313	274	274
query70	1207	1123	1046	1046
query71	471	324	289	289
query72	5440	4702	4582	4582
query73	697	595	360	360
query74	8893	8927	8678	8678
query75	3803	3183	2737	2737
query76	3636	1133	724	724
query77	786	369	280	280
query78	10096	10136	9445	9445
query79	2860	814	576	576
query80	629	501	450	450
query81	466	256	220	220
query82	469	125	93	93
query83	289	247	308	247
query84	292	108	86	86
query85	778	371	316	316
query86	324	289	293	289
query87	4508	4452	4345	4345
query88	3350	2290	2286	2286
query89	405	324	290	290
query90	1934	208	212	208
query91	143	139	108	108
query92	79	55	56	55
query93	2132	978	595	595
query94	677	416	297	297
query95	381	294	285	285
query96	507	563	278	278
query97	2738	2759	2643	2643
query98	221	208	211	208
query99	1426	1404	1258	1258
Total cold run time: 274976 ms
Total hot run time: 184431 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.33 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4713b2c477eeeb60657d5883f38610475d16c8ab, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.25	0.08	0.08
query4	1.61	0.10	0.10
query5	0.43	0.45	0.42
query6	1.17	0.67	0.65
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.60	0.51	0.51
query10	0.58	0.57	0.57
query11	0.15	0.12	0.11
query12	0.16	0.11	0.11
query13	0.63	0.61	0.62
query14	0.81	0.82	0.81
query15	0.90	0.86	0.88
query16	0.38	0.40	0.39
query17	1.03	1.07	1.07
query18	0.23	0.21	0.22
query19	2.01	1.86	1.90
query20	0.02	0.01	0.01
query21	15.39	0.90	0.56
query22	0.76	1.09	0.92
query23	14.71	1.42	0.64
query24	7.09	1.01	0.30
query25	0.29	0.14	0.06
query26	0.67	0.17	0.15
query27	0.06	0.06	0.05
query28	9.47	0.93	0.44
query29	12.57	4.03	3.31
query30	0.25	0.09	0.06
query31	2.84	0.61	0.40
query32	3.25	0.57	0.47
query33	3.17	3.07	3.14
query34	15.88	5.35	4.77
query35	4.85	4.84	4.82
query36	0.69	0.50	0.49
query37	0.10	0.07	0.07
query38	0.06	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.14	0.13
query41	0.09	0.03	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.02
Total cold run time: 103.62 s
Total hot run time: 29.33 s

@wumeibanfa
Copy link
Contributor Author

run cloud_p0

@wumeibanfa
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34858 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4713b2c477eeeb60657d5883f38610475d16c8ab, data reload: false

------ Round 1 ----------------------------------
q1	17626	5196	5145	5145
q2	1941	289	190	190
q3	10295	1323	748	748
q4	10233	1027	534	534
q5	7524	2452	2320	2320
q6	180	161	129	129
q7	905	760	596	596
q8	9305	1394	1066	1066
q9	7416	5126	5066	5066
q10	6928	2360	1964	1964
q11	493	300	288	288
q12	352	362	223	223
q13	17764	3691	3186	3186
q14	222	232	212	212
q15	553	483	480	480
q16	420	447	386	386
q17	612	898	366	366
q18	7466	7220	7162	7162
q19	1086	960	562	562
q20	337	365	233	233
q21	4258	3303	3055	3055
q22	1085	1021	947	947
Total cold run time: 107001 ms
Total hot run time: 34858 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5178	5145	5212	5145
q2	256	331	220	220
q3	2182	2730	2366	2366
q4	1417	1783	1371	1371
q5	4382	4513	4447	4447
q6	211	165	126	126
q7	1953	1920	1841	1841
q8	2667	2580	2502	2502
q9	7115	7052	7209	7052
q10	3139	3313	2837	2837
q11	585	511	473	473
q12	689	787	691	691
q13	3478	4004	3328	3328
q14	269	294	265	265
q15	512	475	468	468
q16	454	479	431	431
q17	1152	1510	1428	1428
q18	7925	7479	7390	7390
q19	835	883	960	883
q20	2047	2097	1870	1870
q21	4918	4455	4359	4359
q22	1070	1008	967	967
Total cold run time: 52434 ms
Total hot run time: 50460 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185961 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4713b2c477eeeb60657d5883f38610475d16c8ab, data reload: false

query1	1007	387	397	387
query2	6536	1728	1767	1728
query3	6748	219	219	219
query4	26322	23726	23144	23144
query5	4418	594	436	436
query6	306	221	209	209
query7	4623	507	293	293
query8	280	229	217	217
query9	8613	2686	2689	2686
query10	483	345	282	282
query11	15458	15029	14939	14939
query12	161	111	105	105
query13	1660	552	421	421
query14	8806	6019	5938	5938
query15	209	201	184	184
query16	7486	656	488	488
query17	1212	741	611	611
query18	2025	412	317	317
query19	203	201	170	170
query20	120	120	115	115
query21	218	133	110	110
query22	4160	4143	4108	4108
query23	33956	33122	33130	33122
query24	8460	2497	2401	2401
query25	522	462	399	399
query26	1232	268	151	151
query27	2749	515	353	353
query28	4292	2148	2122	2122
query29	782	577	448	448
query30	288	218	199	199
query31	903	867	767	767
query32	73	63	63	63
query33	551	361	320	320
query34	827	855	534	534
query35	821	798	759	759
query36	969	989	915	915
query37	119	102	79	79
query38	4237	4127	4073	4073
query39	1465	1418	1437	1418
query40	214	117	107	107
query41	57	54	51	51
query42	123	107	110	107
query43	523	526	469	469
query44	1368	824	824	824
query45	182	167	163	163
query46	881	1028	645	645
query47	1740	1813	1697	1697
query48	386	452	305	305
query49	762	501	396	396
query50	669	735	433	433
query51	4183	4252	4120	4120
query52	109	106	96	96
query53	231	264	194	194
query54	598	576	503	503
query55	87	83	86	83
query56	299	307	309	307
query57	1200	1194	1100	1100
query58	265	263	272	263
query59	2665	2739	2566	2566
query60	335	322	297	297
query61	127	130	125	125
query62	806	735	666	666
query63	232	201	193	193
query64	4298	1044	668	668
query65	4295	4190	4185	4185
query66	1137	420	346	346
query67	15810	15726	15459	15459
query68	7961	913	531	531
query69	464	368	274	274
query70	1250	1106	1135	1106
query71	453	324	301	301
query72	5792	4693	4667	4667
query73	672	600	356	356
query74	9010	9078	8764	8764
query75	3793	3192	2684	2684
query76	3695	1159	753	753
query77	778	405	288	288
query78	9930	10154	9358	9358
query79	3327	826	575	575
query80	664	517	454	454
query81	473	269	222	222
query82	450	125	100	100
query83	297	249	238	238
query84	290	112	87	87
query85	783	428	334	334
query86	338	310	302	302
query87	4490	4485	4417	4417
query88	3280	2301	2271	2271
query89	441	312	296	296
query90	1963	214	215	214
query91	137	143	112	112
query92	70	62	57	57
query93	2876	934	593	593
query94	682	407	304	304
query95	382	298	294	294
query96	487	574	282	282
query97	2755	2799	2642	2642
query98	236	208	210	208
query99	1491	1401	1279	1279
Total cold run time: 276592 ms
Total hot run time: 185961 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.61 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4713b2c477eeeb60657d5883f38610475d16c8ab, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.05
query3	0.24	0.08	0.09
query4	1.61	0.11	0.11
query5	0.45	0.43	0.40
query6	1.18	0.67	0.66
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.60	0.52	0.54
query10	0.58	0.57	0.56
query11	0.16	0.11	0.10
query12	0.14	0.11	0.12
query13	0.63	0.61	0.62
query14	0.80	0.80	0.81
query15	0.91	0.88	0.86
query16	0.40	0.41	0.39
query17	1.05	1.08	1.06
query18	0.24	0.22	0.21
query19	1.95	1.84	1.88
query20	0.01	0.02	0.01
query21	15.41	0.90	0.56
query22	0.76	1.08	0.94
query23	14.71	1.35	0.62
query24	8.87	0.78	0.44
query25	0.41	0.27	0.07
query26	0.58	0.17	0.15
query27	0.07	0.05	0.05
query28	8.33	0.89	0.46
query29	12.55	4.04	3.35
query30	0.25	0.09	0.07
query31	2.85	0.60	0.40
query32	3.23	0.56	0.47
query33	3.07	3.06	3.15
query34	16.13	5.47	4.83
query35	4.82	4.91	4.88
query36	0.71	0.51	0.49
query37	0.09	0.07	0.07
query38	0.06	0.04	0.04
query39	0.04	0.02	0.03
query40	0.18	0.15	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 104.42 s
Total hot run time: 29.61 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

@wumeibanfa wumeibanfa mentioned this pull request Jun 27, 2025
Merged
16 tasks
@zclllyybb zclllyybb self-assigned this Jun 27, 2025
zclllyybb
zclllyybb reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good fix! but I think we need regression test to check this using the interface testFoldConst. since before there's no wrong in P0 test, there must be a missing of corresponding testcase.

@zclllyybb zclllyybb requested a review from morrySnow June 28, 2025 07:55
@zclllyybb
Copy link
Contributor

@morrySnow PTAL

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow changed the title [fix](nereids) fix tanh @ExecFunction(name) [fix](nereids) fix tanh cosntant folding Jun 30, 2025
@zclllyybb zclllyybb merged commit 651fe77 into apache:master Jun 30, 2025
39 of 42 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 30, 2025
@wumeibanfa
[fix](nereids) fix tanh cosntant folding (#52100)
afa0a63 
fix tanh @ExecFunction(name)

change @ExecFunction(name=cosh) to @ExecFunction(name=tanh)
@github-actions github-actions bot mentioned this pull request Jun 30, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jun 30, 2025
@wumeibanfa
[fix](nereids) fix tanh cosntant folding (#52100)
a6dbbda 
fix tanh @ExecFunction(name)

change @ExecFunction(name=cosh) to @ExecFunction(name=tanh)
@github-actions github-actions bot mentioned this pull request Jun 30, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jun 30, 2025
@wumeibanfa
[fix](nereids) fix tanh cosntant folding (#52100)
e8e2987 
fix tanh @ExecFunction(name)

change @ExecFunction(name=cosh) to @ExecFunction(name=tanh)
@github-actions github-actions bot mentioned this pull request Jun 30, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jul 1, 2025
@github-actions @wumeibanfa
branch-3.1: [fix](nereids) fix tanh cosntant folding #52100 (#52546)
5690db9 
Cherry-picked from #52100

Co-authored-by: admiring_xm <86338598+wumeibanfa@users.noreply.github.com>
yiguolei pushed a commit that referenced this pull request Jul 2, 2025
@github-actions @wumeibanfa
branch-2.1: [fix](nereids) fix tanh cosntant folding #52100 (#52527)
06bbfd1 
Cherry-picked from #52100

Co-authored-by: admiring_xm <86338598+wumeibanfa@users.noreply.github.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@wumeibanfa @koarz
[fix](nereids) fix tanh cosntant folding (apache#52100)
fe46084 
fix tanh @ExecFunction(name)

change @ExecFunction(name=cosh) to @ExecFunction(name=tanh)
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@wumeibanfa @koarz
[fix](nereids) fix tanh cosntant folding (apache#52100)
64a6301 
fix tanh @ExecFunction(name)

change @ExecFunction(name=cosh) to @ExecFunction(name=tanh)
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@wumeibanfa @koarz
[fix](nereids) fix tanh cosntant folding (apache#52100)
6b37fc5 
fix tanh @ExecFunction(name)

change @ExecFunction(name=cosh) to @ExecFunction(name=tanh)
dataroaring pushed a commit that referenced this pull request Jul 7, 2025
@github-actions @wumeibanfa
branch-3.0: [fix](nereids) fix tanh cosntant folding #52100 (#52526)
ed8a4cf 
Cherry-picked from #52100

Co-authored-by: admiring_xm <86338598+wumeibanfa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zclllyybb zclllyybb

@Jibing-Li Jibing-Li

@morrySnow morrySnow

Assignees

@zclllyybb zclllyybb

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.11-merged dev/3.0.7-merged dev/3.1.0-merged p0_w reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@wumeibanfa @Thearas @doris-robot @hello-stephen @zclllyybb @Jibing-Li @morrySnow @yiguolei @dataroaring