Skip to content

fix: add tabindex to activedescendant #3121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kush-savani
Copy link
Contributor

Closes #3120

Dropdown

    tag was not focusable, due to tabindex: -1. Accessibility report suggest to set as 0.
    Before:
    Screenshot 2025-03-13 at 4 26 24 PM

    After:
    Screenshot 2025-03-13 at 4 26 02 PM

    Changelog

    New

    • {{new thing}}

    Changed

    • {{change thing}}

    Removed

    • {{removed thing}}

@kush-savani kush-savani requested a review from a team as a code owner March 13, 2025 11:02
Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 611464d
🔍 Latest deploy log https://app.netlify.com/projects/carbon-components-angular/deploys/685e0334a8236d0008908bf6
😎 Deploy Preview https://deploy-preview-3121--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Akshat55 Akshat55 changed the title fix(dropdown-list): set ul element to focusable fix: add tabindex to activedescendant Jun 27, 2025
@Akshat55 Akshat55 enabled auto-merge (squash) June 27, 2025 02:35
@Akshat55 Akshat55 disabled auto-merge June 27, 2025 02:35
@Akshat55 Akshat55 merged commit 9438b3b into carbon-design-system:master Jun 27, 2025
14 checks passed
Copy link

🎉 This PR is included in version 5.58.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown list <ul> element is not focusable
3 participants