-
-
Notifications
You must be signed in to change notification settings - Fork 320
Add intl support for windows #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
why will this close imagick support? |
Sorry, I made a mistake. I just finished doing housework and feel dizzy :P |
ah, got it |
/cc @simonhamp Sorry to bother you, but I don't have a working test case or existing project to test intl extensions on windows. I would be grateful if you could test it and provide feedback. |
@crazywhalecc @henderkes This will be a game changer for Laravel + Windows. Thanks for adding. |
Nice! I'll try to get to this soon |
Hello @crazywhalecc , I can confirm that this works!!! I successfully built a custom PHP binary for a Windows target, which resolved the missing I've built the binary for php8.4
|
@abderrahmane-mhd Thank you for testing. It would be better if you could test its function working well with real project. Because we have lower maintain priority on windows build, and windows may contain some invisible bug that cannot reproduce in CI. |
I've tested it in a real symfony project and it works. Can be merged. |
What does this PR do?
ICU is built using vcpkg from static-php-cli-hosted. Since vcpkg integration has not yet been implemented, use solution 1 to temporarily support intl extension. The current implementation is very straightforward.
Closes #435
Checklist before merging
*.php
, runcomposer cs-fix
at local machine.src/global/test-extensions.php
../docs/
.config/xxx.json
content, runbin/spc dev:sort-config xxx
.