-
Notifications
You must be signed in to change notification settings - Fork 824
17.14 - increase fsharpcore build version number #18718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
#### AI description (iteration 1) #### PR Classification This pull request is for a NuGet patch release, focusing on updating build configurations and dependencies. #### PR Summary This pull request updates build scripts and configuration files to support a new NuGet patch release, ensuring compatibility with updated Microsoft Build packages. - `/eng/build.sh`: Added no-operation implementations for `--runtimesourcefeed` and `--runtimesourcefeedkey` arguments. - `/eng/Versions.props`: Updated Microsoft Build package versions to use a unified `MicrosoftBuildVersion` variable. - `/eng/SourceBuildPrebuiltBaseline.xml`: Added new usages for Microsoft Build packages with version `17.13.26`. - `/azure-pipelines.yml`: Enabled internal sources for source build parameters. - `/NuGet.config`: Added a new package source for `msbuild-Trusted`. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
rel/d17.14 ---- #### AI description (iteration 1) #### PR Classification NuGet package update for a specific release branch. #### PR Summary This pull request updates the Azure Pipelines configuration to target the `rel/d17.14` branch for Visual Studio insertion. This change ensures that the build and release processes are aligned with the correct branch for the upcoming release. - Updated `azure-pipelines.yml` to set `VSInsertionTargetBranchName` to `rel/d17.14`. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
✅ No release notes required |
Otel exported led to a fatal crash in CI: [xUnit.net 00:00:00.79] FSharp.Build.UnitTests: Catastrophic failure: System.IO.FileNotFoundException: Could not load file or assembly 'System.Threading.Tasks.Extensions, Version=4.2.0.1, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified. File name: 'System.Threading.Tasks.Extensions, Version=4.2.0.1, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' at OpenTelemetry.Trace.TracerProviderBuilderBase.Build() at OpenTelemetry.Trace.TracerProviderBuilderExtensions.Build(TracerProviderBuilder tracerProviderBuilder) at <StartupCode$FSharp-Test-Utilities>.$XunitHelpers.CreateExecutor@130.RunTestCases(IEnumerable`1 testCases, IMessageSink executionMessageSink, ITestFrameworkExecutionOptions executionOptions) in D:\a\_work\1\s\tests\FSharp.Test.Utilities\XunitHelpers.fs:line 142 Revisit this with conditional setting or a binding redirect
@dotnet/source-build-internal : Due to failing tests which related to usage of msbuild .dll (legacy project system which powers VS behavior for non-SDK style projects in VS), I had to update MS.Build.* dlls. That in sequence lead to nuget mismatches, which I had to resolve by updating system packages to match what those msbuild packages needed. This change is for a servicing branch only (aiming 9.0.303) and will not flow to main. Is it in that case acceptable to have a change in prebuilt baseline? |
Source build only builds out of 1xx feature bands (we plan to support multiple bands for 10.0). So yes, as long as these changes don’t flow to 9.0.1xx or main, it is acceptable to add the prebuilts to the prebuilt baseline. |
Thank you @ellahathaway . |
Address #18712