Skip to content

17.14 - increase fsharpcore build version number #18718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 10, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<FSCorePackageVersionValue>$(FSMajorVersion).$(FSMinorVersion).$(FSBuildVersion)</FSCorePackageVersionValue>
<FSCoreVersionPrefix>$(FSMajorVersion).$(FSMinorVersion).$(FSBuildVersion)</FSCoreVersionPrefix>
<FSCoreVersion>$(FSMajorVersion).$(FSMinorVersion).0.0</FSCoreVersion>
<FSCoreShippedVersion>9.0.0.0</FSCoreShippedVersion>
<FSCoreShippedVersion>9.0.300.0</FSCoreShippedVersion>
<!-- -->
<!-- FSharp.Compiler.Service version -->
<FCSMajorVersion>43</FCSMajorVersion>
Expand Down Expand Up @@ -102,7 +102,7 @@
<MicrosoftVisualStudioShellPackagesVersion>17.10.40152</MicrosoftVisualStudioShellPackagesVersion>
<VisualStudioProjectSystemPackagesVersion>17.10.526-pre-g1b474069f5</VisualStudioProjectSystemPackagesVersion>
<MicrosoftVisualStudioThreadingPackagesVersion>17.10.41</MicrosoftVisualStudioThreadingPackagesVersion>
<MicrosoftBuildVersion>17.13.22</MicrosoftBuildVersion>
<MicrosoftBuildVersion>17.14.8</MicrosoftBuildVersion>
<!-- Roslyn packages -->
<MicrosoftCodeAnalysisEditorFeaturesVersion>$(RoslynVersion)</MicrosoftCodeAnalysisEditorFeaturesVersion>
<MicrosoftCodeAnalysisEditorFeaturesTextVersion>$(RoslynVersion)</MicrosoftCodeAnalysisEditorFeaturesTextVersion>
Expand Down Expand Up @@ -138,9 +138,9 @@
<MicrosoftVisualStudioShellImmutable150Version>15.0.25123-Dev15Preview</MicrosoftVisualStudioShellImmutable150Version>
<!-- -->
<!-- Microsoft Build packages -->
<MicrosoftBuildFrameworkVersion>17.13.22</MicrosoftBuildFrameworkVersion>
<MicrosoftBuildTasksCoreVersion>17.13.22</MicrosoftBuildTasksCoreVersion>
<MicrosoftBuildUtilitiesCoreVersion>17.13.22</MicrosoftBuildUtilitiesCoreVersion>
<MicrosoftBuildFrameworkVersion>17.14.8</MicrosoftBuildFrameworkVersion>
<MicrosoftBuildTasksCoreVersion>17.14.8</MicrosoftBuildTasksCoreVersion>
<MicrosoftBuildUtilitiesCoreVersion>17.14.8</MicrosoftBuildUtilitiesCoreVersion>
<!-- -->
<!-- Visual Studio Editor packages -->
<MicrosoftVisualStudioCoreUtilityVersion>$(VisualStudioEditorPackagesVersion)</MicrosoftVisualStudioCoreUtilityVersion>
Expand Down
12 changes: 12 additions & 0 deletions vsintegration/tests/Salsa/VsMocks.fs
Original file line number Diff line number Diff line change
Expand Up @@ -1375,6 +1375,8 @@ module internal VsMocks =
let vsTargetFrameworkAssemblies40 = vsTargetFrameworkAssembliesN 0x40000u
let vsTargetFrameworkAssemblies45 = vsTargetFrameworkAssembliesN 0x40005u
let vsTargetFrameworkAssemblies46 = vsTargetFrameworkAssembliesN 0x40006u
let vsTargetFrameworkAssemblies47 = vsTargetFrameworkAssembliesN 0x40007u
let vsTargetFrameworkAssemblies48 = vsTargetFrameworkAssembliesN 0x40008u

let vsFrameworkMultiTargeting =
{ new IVsFrameworkMultiTargeting with
Expand Down Expand Up @@ -1601,6 +1603,16 @@ module internal VsMocks =
sp.AddService(typeof<SVsTargetFrameworkAssemblies>, box vsTargetFrameworkAssemblies46, false)
sp.AddService(typeof<SVsFrameworkMultiTargeting>, box vsFrameworkMultiTargeting, false)
sp, ccn
let MakeMockServiceProviderAndConfigChangeNotifier47() =
let sp, ccn = MakeMockServiceProviderAndConfigChangeNotifierNoTargetFrameworkAssembliesService()
sp.AddService(typeof<SVsTargetFrameworkAssemblies>, box vsTargetFrameworkAssemblies47, false)
sp.AddService(typeof<SVsFrameworkMultiTargeting>, box vsFrameworkMultiTargeting, false)
sp, ccn
let MakeMockServiceProviderAndConfigChangeNotifier48() =
let sp, ccn = MakeMockServiceProviderAndConfigChangeNotifierNoTargetFrameworkAssembliesService()
sp.AddService(typeof<SVsTargetFrameworkAssemblies>, box vsTargetFrameworkAssemblies48, false)
sp.AddService(typeof<SVsFrameworkMultiTargeting>, box vsFrameworkMultiTargeting, false)
sp, ccn

// This is the mock thing that all tests, except the multitargeting tests call.
// By default, let it use the 4.0 assembly version.
Expand Down
2 changes: 2 additions & 0 deletions vsintegration/tests/UnitTests/TestLib.ProjectSystem.fs
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,8 @@ type TheTests() =
File.AppendAllText(file, TheTests.FsprojTextWithProjectReferencesAndOtherFlags(compileItems, references, [], null, other, targetFramework))
let sp, cnn =
match targetFramework with
| "v4.8" -> VsMocks.MakeMockServiceProviderAndConfigChangeNotifier48()
| "v4.7" -> VsMocks.MakeMockServiceProviderAndConfigChangeNotifier47()
| "v4.6" -> VsMocks.MakeMockServiceProviderAndConfigChangeNotifier46()
| "v4.5" -> VsMocks.MakeMockServiceProviderAndConfigChangeNotifier45()
| "v4.0" -> VsMocks.MakeMockServiceProviderAndConfigChangeNotifier40()
Expand Down
Loading