Minor fix(?) for lsp-ui-imenu--visit and lsp-ui-imenu--view #274
Description
In lsp-ui-imenu--visit and lsp-ui-imenu--view, replace
(goto-char marker)
with
(goto-char (overlay-start marker))
Without the above changes I get the following error
funcall-interactively: Wrong type argument: integer-or-marker-p, #<overlay from 16721 to 16752 in xdisp.c>
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Participants
Activity
c02y commentedon Sep 11, 2020
@emacksnotes Agree, I got the same problem, your code line fixes it.
It's over a year, maybe post a PR?
UPDATE:
I was wrong, the fix-code works only for some simple file such as a source not managed by ccls/lsp, for projects(compile_commands.json), it doesn't work.
Without the fix, In
lsp-ui-imenu--visitandlsp-ui-imenu--viewworks without problem.jcs090218 commentedon Sep 11, 2020
@emacksnotes @c02y Feel free to open a PR! There will be people reviewing it! 😄
c02y commentedon Sep 11, 2020
@jcs090218 I added an update, this fix will break those two functions.
But for a simple source file,
lsp-ui-imenu--visitandlsp-ui-imenu--viewfunctions should work too. It still needs update, just not simple(goto-char (overlay-start marker))