Skip to content

Conversation

@kleisauke
Copy link
Collaborator

No description provided.

@kleisauke
Copy link
Collaborator Author

This got me thinking, perhaps we should migrate this to a submodule? I'm not sure it's feasible for the system/ directory though, since it would complicate cloning (you'd need to use --recurse-submodules). I'm also not sure if emsdk already handles that.

@sbc100
Copy link
Collaborator

sbc100 commented Jun 10, 2025

This got me thinking, perhaps we should migrate this to a submodule? I'm not sure it's feasible for the system/ directory though, since it would complicate cloning (you'd need to use --recurse-submodules). I'm also not sure if emsdk already handles that.

Emscripten already uses a couple of submodules (today they are only for developers / testing) but it should be fine to start using them more.

However, we already include copies of musl / libc++ / compiler-rt and libc++abi, so converting this tiny library to a submodule would not make much difference to amount of verbatim copying we have.

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if the tests pass.

Is this the latest official release?

@kleisauke
Copy link
Collaborator Author

Is this the latest official release?

Yes, this is the latest stable (non-beta) release. See e.g. https://github.com/microsoft/mimalloc/tags (v3.1.4 is still in beta).

//----------------------------------------------------------------

#ifdef __EMSCRIPTEN_SHARED_MEMORY__
#if defined(MI_USE_PTHREADS)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants