Fix race condition in browser.test_clientside_vertex_arrays_es3 #24576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Jun 16, 2025
test/clientside_vertex_arrays_es3.c
Outdated
| #ifdef __EMSCRIPTEN__ | ||
| // This test kicks off an asynchronous main loop, so do not perform a synchronous | ||
| // reftest immediately after falling out from main. | ||
| EM_ASM({ delete Module['postRun']; }); |
There was a problem hiding this comment.
Use reftestBlock/reftestUnlock API
juj
force-pushed
the
fix_clientside_vertex_arrays_test
branch
from
a186277 to
d055b5e
Compare
|
Can you remind me what the race condition is here exactly? (Perhaps you can give a brief description in the PR description). |
|
ok, updated description. |
|
Hmm.. I wonder if we can/should instead have the reftest be more smart here.. so that we can avoid changing each of these tests. I'm happy to see this change land as-is, but I feel like there should be a cleaner way to do this. |
sbc100
approved these changes
Aug 14, 2025
|
If there is a better design, would be happy for it - I don't unfortunately have time for larger refactors, but I need to work the CI to show up green in order to start merging our Emscripten fork PRs to upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, browser would run the reftest as a Module['postRun'] trigger immediately after finishing main().
But because reftest is asynchronous, as it has to load an image asynchronously, the requestAnimationFrame() timers might race to squeeze in the needed test tick function call to render the expected image, or they might not, if the XHR of the reftest image is fast.