[embind] Allow Closure to compress registerType methods #24610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason 'fromWireType', 'toWireType' and 'readValueFromPointer' were always protected from Closure is because we dynamically generate JS functions, and property mangling would make it impossible for the dynamically generated code to access properties declared statically. However, we can easily work around that by binding corresponding methods outside of the generated lambdas, and passing just the methods instead of the whole type object.
sbc100
reviewed
Jun 19, 2025
Fairly sure, as they are only needed for type registration, but I'll wait for @brendandahl to review as well. |
|
Actually, yeah, I rechecked, this JavaScript API is not part of our public API anywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason 'fromWireType', 'toWireType' and 'readValueFromPointer' were always protected from Closure is because we dynamically generate JS functions, and property mangling would make it impossible for the dynamically generated code to access properties declared statically.
However, we can easily work around that by binding corresponding methods outside of the generated lambdas, and passing just the methods instead of the whole type object.