@react-native/js-polyfills: polyfill console.timeStamp #52168
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76987507 |
|
This pull request was exported from Phabricator. Differential Revision: D76987507 |
Summary: Pull Request resolved: facebook#52187 # Changelog: [Internal] - `tracing_` is now `std::atomic<bool>`. - `performanceMeasureCount_` is now`std::atomic<uint32_t>`. - `mutex_` -> `tracingMutex_`. The biggest change is that we no longer read from `tracing_` directly for an early-return when not tracing. This should not significantly regress performance of the subsystem, see the test plan for numbers. Differential Revision: D77053030
Summary: # Changelog: [Internal] `buffer_.push_back` -> `buffer_.emplace_back` I didn't measure if there were any runtime wins from this, because I don't expect there would be. Let's avoid potential copies, if possible. Differential Revision: D77053032
Summary: # Changelog: [Internal] Probably been overlooked for quite some time, but shouldn't be a bottleneck. Differential Revision: D77148271
…er operations Summary: # Changelog: [Internal] Mainly, 2 changes: 1. `PerformanceTracer::serializeTraceEvent(const TraceEvent& event)` -> `PerformanceTracer::serializeTraceEvent(TraceEvent&& event)` for less copies, actually move strings from the `TraceEvent` into the serialized `folly:object`. 2. When collecting events from the buffer, only lock when accessing buffer, not when serializing. Differential Revision: D77164969
Summary: # Changelog: [Internal] The main reason for the stub is to make sure this method is always installed. The actual implementation will be part of the `jsinspector-modern` stack, which is fully initialized in production builds. Once there is a gurantee that RuntimeTarget globals are always installed in any environments, we can remove polyfills altogether. Reviewed By: rubennorte, GijsWeterings Differential Revision: D76987507
|
This pull request was exported from Phabricator. Differential Revision: D76987507 |
|
This pull request has been merged in c612ae4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
The main reason for stubbing-out this is to make sure this method is always installed. The actual implementation will be part of the
jsinspector-modernstack, which is fully initialized in production builds.Once there is a gurantee that RuntimeTarget globals are always installed in any environments, we can remove polyfills altogether.
Differential Revision: D76987507