feat: ignore ipynb files during apply #5177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -104,6 +104,7 @@ def get_repo_files(repo_root: Path) -> List[Path]: | |||
| p.resolve() | |||
| for p in repo_root.glob("**/*.py") | |||
| if p.is_file() and "__init__.py" != p.name | |||
| and not p.name.endswith(".ipynb") # Ignore Jupyter Notebook files during feast apply | |||
There was a problem hiding this comment.
also if you can add .ipynb_checkpoints to ignore
| @@ -104,6 +104,7 @@ def get_repo_files(repo_root: Path) -> List[Path]: | |||
| p.resolve() | |||
| for p in repo_root.glob("**/*.py") | |||
| if p.is_file() and "__init__.py" != p.name | |||
| and not p.name.endswith(".ipynb") # Ignore Jupyter Notebook files during feast apply | |||
There was a problem hiding this comment.
can we make this a list of files we ignore and add .ipynb to it?
There was a problem hiding this comment.
Interestingly, I see .ipynb_checkpoints in the ignore_paths but I have experienced this issue locally very frequently.
There was a problem hiding this comment.
me too, I just used to do find . -name ".ipynb_checkpoints" -type d -exec rm -rf {} +
There was a problem hiding this comment.
yeah i do something similar
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Ignore Jupyter Notebook Files extensions when using feast apply
Which issue(s) this PR fixes:
Fixes #5145