feat: Snowflake source. fetch MAX in a single query #5387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Petrov <58334441+wckdman@users.noreply.github.com>
wckdman
force-pushed
the
feat-snowflake-get-types-in-one-query
branch
from
ea11ea0 to
e80cf16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Default precision in Snowflake is 38 (Docs).
Current realisation executes a bunch of
MAX(column)queries to check the exact precision.This PR introduces a small optimisation to execute a single query for all columns.
Which issue(s) this PR fixes:
N/A
Misc
N/A