-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: Update minimum protobuf version to >=6.30.2 #5458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: misohu <michal.hucko@canonical.com>
@misohu Thanks for the report and fix, please modify https://github.com/feast-dev/feast/blob/master/setup.py#L36 and run |
Hey @ntkathole thanks for your message. Looks like the resolution fails with
|
You might need to pin grpcio-* to upgraded versions |
Hey @ntkathole ok found some version ... now having problems with the
I have this installed
The pixi env has some problems
I am running the make with uv env activated |
Hey, thanks for contributing. Some of the companies are still using 4.25.x. So before bumping to 5.x we need to be really careful about it. Instead. I think a temporary fix should be lower the upper bound for protobuf version. |
What this PR does / why we need it:
This PR updates the minimum required
protobuf
version inpyproject.toml
to>=6.30.2
.The current version range (
>=3.20.3,<7
) allows older versions like4.25.6
or5.26.0
that do not includegoogle.protobuf.runtime_version
, which is used by Feast internally. This causes anImportError
when importing modules likeFeatureStore
.Updating the minimum ensures that users install a compatible version of
protobuf
and avoids runtime failures.Which issue(s) this PR fixes:
Fixes #5457