-
Notifications
You must be signed in to change notification settings - Fork 46
Removed deprecated calls in Analytics, Auth, and Messaging #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on proactive code maintenance by removing deprecated API calls within the Analytics, Authentication, and Messaging components. This cleanup is essential for preparing the codebase for upcoming breaking changes and ensures that only current and supported functionality remains, improving the overall health and maintainability of the project.
Highlights
- Code Cleanup: I've removed several deprecated methods and properties across the Analytics, Auth, and Messaging modules. This includes specific API calls that were previously marked as obsolete and are no longer needed or have been superseded by newer alternatives.
- API Modernization: Specifically, I've removed
FirebaseAnalytics.ParameterGroupId
,FirebaseUser.UpdateEmailAsync
, and variousDispose
methods that were marked as deprecated and no longer served a purpose inParameter
,FirebaseMessage
,FirebaseNotification
, andMessagingOptions
classes. - Documentation Update: I've updated the
docs/readme.md
file to include an 'Upcoming' section in the release notes, explicitly listing the deprecated APIs that have been removed in this change.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes deprecated APIs from Analytics, Auth, and Messaging. It's important to remove the IDisposable
interface from the Parameter
class and clarify the release notes.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a readme nit
Description
Remove the deprecated calls in Analytics, Auth, and Messaging, in preparation for the upcoming breaking change.
Testing
Type of Change
Place an
x
the applicable box: