Skip to content

cast: rm expect dependency_on_unit_never_type_fallback #10872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Jun 28, 2025

Motivation

cargo build raises the below warning:

> warning: this function depends on never type fallback being `()`
>    --> crates/cast/src/cmd/send.rs:89:5
>     |
> 89  |     pub async fn run(self) -> eyre::Result<()> {
>     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>     |
>     = help: specify the types explicitly
> note: in edition 2024, the requirement `for<'de> !: Deserialize<'de>` will fail
>    --> crates/cast/src/cmd/send.rs:157:26
>     |
> 157 |                         .raw_request(
>     |                          ^^^^^^^^^^^
> help: use `()` annotations to avoid fallback changes
>     |
> 157 |                         .raw_request::<_, ()>(
>     |                                     +++++++++
>

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Signed-off-by: jsvisa <delweng@gmail.com>
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, this will become a hard error with 2024 I believe

@mattsse mattsse merged commit 4808664 into foundry-rs:master Jun 28, 2025
42 of 44 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Jun 28, 2025
@jsvisa jsvisa deleted the cast-send-dependency branch June 28, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants