Improved so that the AI bot responds to personal messages and to messages in which it was mentioned #9334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connected to Huly®: UBERF-11731 |
BykhovDenis
requested review from
kristina-fefelova and
Copilot
and removed request for
kristina-fefelova
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the AI bot response logic to improve the handling of personal messages and mentions while preserving existing direct message functionality. Key changes include:
- Extraction of helper functions (findAiBotSocialIdentity, findAiBotAllSocialIds, isThreadMessage, getMessageDoc, isDirectAvailable, isAiBotShouldReplay, and OnAiBotShouldReplay) to organize message processing logic.
- Update of message filtering and condition checks to decide when the AI bot should send a response.
- Removal of duplicate code and streamlining of direct and thread message handling.
Comments suppressed due to low confidence (1)
server-plugins/ai-bot-resources/src/index.ts:154
- [nitpick] Consider renaming 'isAiBotShouldReplay' to 'isAiBotShouldReply' to more clearly reflect its purpose of determining whether the AI bot should reply to a message.
): Promise<boolean> {
RoadRoller
force-pushed
the
ai-bot-improvements
branch
from
4917372 to
6179dba
Compare
…at mention it (hcengineering#9328) Signed-off-by: Evgeny Tarasenko <tarasenko.evgeny@gmail.com>
Signed-off-by: Evgeny Tarasenko <tarasenko.evgeny@gmail.com>
RoadRoller
force-pushed
the
ai-bot-improvements
branch
from
d245b1c to
018d43c
Compare
| const isDirect = | ||
| messageDoc._class === chunter.class.DirectMessage && (await isDirectAvailable(messageDoc as DirectMessage, control)) | ||
| const isAiBotPersonalChat = messageDoc._id === aiBotPersonId | ||
| const isAiBotMentioned = message.message.includes(aiBotPersonId) |
There was a problem hiding this comment.
It's not enough to check just includes(id). We need to ensure there's a mention node and inspect its attributes to confirm it's indeed referencing ai. You can look at how isDocMentioned works in server-plugins/activity-resources/src/references.ts.
There was a problem hiding this comment.
Thank you, refactored with honest checking in references.
Signed-off-by: Evgeny Tarasenko <tarasenko.evgeny@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would also suggest switching from the openai library to https://ai-sdk.dev in the ai-bot service so as not to depend on OpenAI as a provider, but I did not understand how to test the functionality of calling tools from the UI and I am afraid of breaking something.
Resolves #9328