Skip to content

feat(ping): ignore certificate error and show request duration #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)
  • Documentation is up to date. Create a pull request here.

Closes #3540

Screenshots
image

@Meierschlumpf Meierschlumpf self-assigned this Jul 4, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner July 4, 2025 16:58
@Meierschlumpf Meierschlumpf added the enhancement New feature or request label Jul 4, 2025
Copy link

deepsource-io bot commented Jul 4, 2025

Here's the code health analysis summary for commits 66f663a..795d357. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Jul 4, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.48% 11461 / 50966
🔵 Statements 22.48% 11461 / 50966
🔵 Functions 29.94% 503 / 1680
🔵 Branches 65.26% 1381 / 2116
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/api/src/router/widgets/app.ts 36.66% 100% 100% 36.66% 17-39
packages/cron-jobs/src/jobs/ping.ts 30% 100% 0% 30% 11-13, 18-28, 31-33
packages/redis/src/index.ts 100% 100% 100% 100%
packages/request-handler/src/ping.ts 29.03% 100% 0% 29.03% 25-26, 31-50
packages/widgets/src/app/component.tsx 0% 0% 0% 0% 1-120
packages/widgets/src/app/ping/ping-indicator.tsx 0% 0% 0% 0% 1-44
Generated in workflow #7255 for commit 795d357 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: remove certificate checks for simple ping
2 participants