Skip to content

Use macOS download folder instead of caches for downloads #3659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Jun 18, 2025

Summary

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal requested a review from Copilot June 18, 2025 14:47
@bgoncal bgoncal self-assigned this Jun 18, 2025
@bgoncal bgoncal added the scout label Jun 18, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the download directory logic to use the macOS Downloads folder under Catalyst and adjusts cleanup and folder-opening behavior in the download manager view.

  • Switches from caches directory to Downloads directory for macOS Catalyst builds
  • Adjusts download cleanup logic to preserve files on macOS
  • Opens the system Downloads folder when a download finishes on Catalyst

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
Sources/Shared/Environment/AppConstants.swift Use .downloadsDirectory for Catalyst and create folder
Sources/App/WebView/DownloadManager/DownloadManagerView.swift Preserve files on Catalyst and open Downloads folder

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 45.47%. Comparing base (4f60d68) to head (27f2b35).
Report is 49 commits behind head on master.

Files with missing lines Patch % Lines
Sources/Shared/Environment/AppConstants.swift 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3659      +/-   ##
==========================================
+ Coverage   44.72%   45.47%   +0.75%     
==========================================
  Files         232      232              
  Lines       13911    14035     +124     
==========================================
+ Hits         6221     6383     +162     
+ Misses       7690     7652      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bgoncal bgoncal merged commit 1b0bfa1 into master Jun 19, 2025
14 checks passed
@bgoncal bgoncal deleted the macos-download-folder branch June 19, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant