fix/timesync: Make timesync work with fallbacks and repolling #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IDisposable
commented
Jun 13, 2025
IDisposable
force-pushed
the
fix/timesync
branch
from
130f07f to
f6de0ab
Compare
IDisposable
changed the title
IDisposable
force-pushed
the
fix/timesync
branch
from
f6de0ab to
641fc01
Compare
IDisposable
force-pushed
the
fix/timesync
branch
2 times, most recently
from
a9c5ff9 to
00ef587
Compare
|
Rebased and tested |
IDisposable
commented
Jul 11, 2025
|
Fixed the two go lint issues formatting (trailing tabs on merged line) and not using the NTP fallback hostnames. Also now logs out the final new time (and mode that it was fetched via) |
IDisposable
force-pushed
the
fix/timesync
branch
2 times, most recently
from
58967db to
695c876
Compare
|
Rebased to dev |
1 task
- Added check to not attempt auto update if time sync is needed and not yet successful (delays 30 second to recheck). - Added resync of time when DHCP or link state changes if online - Added conditional* fallback from configured* NTP servers to the IP-named NTP servers, and then to the DNS named ones if that fails - Added conditional* fallback from the configured* HTTP servers to the default DNS named ones. - Uses the configuration* option for how many queries to run in parallel - Added known static IPs for time servers (in case DNS resolution isn't up yet) - Added time.cloudflare.com to fall-back NTP servers - Added fallback to NTP via hostnames - Logs the resultant time (and mode)
IDisposable
force-pushed
the
fix/timesync
branch
from
695c876 to
ba23da6
Compare
|
Rebased :) |
ym
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving issues with JetKVM devices not being able to contact any NTP servers to get time (and thus the clock is wrong, and thus the SSL negotiations fail, and thus auto update checks fail). This change can target DEV and MAIN.