Skip to content

feat(ui): Add deviceName or deviceID to the browser tab title #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

IDisposable
Copy link
Contributor

Addresses #304. In local mode will show the deviceId, in cloud connection will show the deviceName.

Would be nice to show the hostname, but that would require device-side code changes to the /device endpoint.

image

@IDisposable
Copy link
Contributor Author

To make it show the hostname would require a device-side change (which I can easily do) for the /device endpoint, but that would modify the RPC responses, so we need someone like @ym or @adamshiervani to give their blessing.

I did NOT change the top-left as suggested in #304 as it's actually an SVG image, not an H1... we certainly could insert the name right after that JetKVM logo as whatever, but would need a blessing and CSS styling from the same fine JetKVM employees.

@IDisposable
Copy link
Contributor Author

Would setting the status chicklet look nice? (mocked up as Jetty on this screenshot)

image

@IDisposable IDisposable changed the title feat(ui) Add deviceName or deviceID to the browser tab title feat(ui): Add deviceName or deviceID to the browser tab title Jun 13, 2025
Addresses jetkvm#304. In local mode will show the deviceId, in cloud connection will show the deviceName.

Would be nice to show the hostname, but that would require device-side code changes to the /device endpoint.
@IDisposable IDisposable force-pushed the feat(ui)/show-kvm-name branch from 0078d50 to 17b364b Compare June 17, 2025 16:19
This was referenced Jun 17, 2025
@ym ym requested a review from adamshiervani June 19, 2025 06:38
@adamshiervani
Copy link
Contributor

adamshiervani commented Jul 11, 2025

Totally agree on the need to differentiate the device UI when managing multiple devices - it’s essential for clarity.

In cloud environments, this is relatively straightforward. Each cloud device already has a name, which we can start displaying in the UI - for example, in document.title and the menu bar.

The challenge is with local environments. What should we display there — the cloud name? The device ID? The hostname? Introducing a new property could help, but using the hostname as-is isn’t ideal, especially since it often needs to be a valid FQDN.

Things get more complicated when we have multiple data sources: one from the Cloud DB and one from the Local device. If there’s a collision between them, it can be quite confusing.

@IDisposable
Copy link
Contributor Author

You make the call what you want it to be, and which places (to right of logo and/or in connection status chip) and I'll happily pivot.

My personal suggestion is that the cloud name be something that can be set in the device config... as it is now, we have to delete/disassociate the JetKVM and readd in the cloud to change the name...

@IDisposable IDisposable deleted the feat(ui)/show-kvm-name branch July 11, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants