Skip to content

Utils: Correctly handle the trailing slash in credential embedded URLs #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025

Conversation

kriztalz
Copy link
Contributor

@kriztalz kriztalz commented Jun 3, 2025

This PR allows the use of custom instances with credentials without a trailing slash.
eg: https://user:pass@mytedditinstance.com/ will be properly parsed into https://user:pass@mytedditinstance.com

It echoes to the previous issue reported in #996 which was fixed but not for embebded credential URLs.

@ManeraKai ManeraKai merged commit 138be20 into libredirect:master Jun 28, 2025
@ManeraKai
Copy link
Member

There were 2 statements doing the same thing. I only kept the regex one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants