Skip to content

Conversation

ChromeQ
Copy link

@ChromeQ ChromeQ commented Apr 12, 2022

In relation to React props should not do anything special with children and DefinitelyTyped have updated the react types to v18

DefinitelyTyped/DefinitelyTyped#59802

Copy link

@dhassouni dhassouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, low risk

@simon-rad
Copy link

Any update here? No way to switch to React 18 without this fix

@ChromeQ
Copy link
Author

ChromeQ commented Aug 7, 2022

Can we get this merged?

@abettadapur
Copy link
Collaborator

I am unfortunately not an admin on this project anymore, so I am unable to bypass a broken CI check

@rishab85
Copy link

Any update on this ? it would be nice if could merge this PR.

@tvanrijn
Copy link

Can this get merged and released? Waiting on this fix.

@avianate
Copy link

Any updates on when this will be merged?

@dagadbm
Copy link

dagadbm commented Mar 10, 2025

Any updates? This is blocking any ability to upgrade to react 18

@ChromeQ ChromeQ closed this by deleting the head repository Oct 4, 2025
@dagadbm
Copy link

dagadbm commented Oct 4, 2025

why was this deleted?

@ChromeQ
Copy link
Author

ChromeQ commented Oct 4, 2025

I was cleaning up my personal repos and didn't realise it was linked to an open PR.
I also have zero confidence this will get merged as the project seems dead with last commit almost 3 years ago, plus I personally moved on from using redux-dynamic-modules. Sorry.

The PR changes are still visible so you can create your own fork if you were relying on it.

@dagadbm
Copy link

dagadbm commented Oct 4, 2025

can you share how you moved away from it?

@ChromeQ
Copy link
Author

ChromeQ commented Oct 5, 2025

can you share how you moved away from it?

I meant that I don't maintain the project which used this, in my new project I don't use Redux at all and use react context and providers instead.

You can also use patch-package to apply these changes in your local node_modules rather than fork or maintain a package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants