Fix: Handle empty union type #1005
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
When an empty union is defined,
conjure-python
will incorrectly generate code with syntax error like:After this PR
For backward compat, we have to handle the scenario post-hoc, i.e. after codegen. The wire spec doesn't explicitly state whether an empty union is allowed, but here I'm just throwing an exception during runtime anyway (it won't break existing generated binding per se - since they should be already broken by the syntax error) since relaxation is easier than tightening up if there's a change of plan.
==COMMIT_MSG==
Handle empty union type
==COMMIT_MSG==
Possible downsides?