fix: fix findCustomID
to prevent early escape
#13010
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Don't return a truthy value for group-like fields and discontinue field traversal within the
findCustomID
callback function.Why?
Currently, there is a bug that prevents
customIDType
being set correctly when the custom ID field is placed after atabs
field that includes a tab with aname
, since the first condition will returntrue
and prevent further field traversal. This bug only becomes apparent when using anumber
type for the custom ID field, sincecustomIDType
isundefined
so the typing defaults totext
(breaking field validation, as well as<Document>
views wherefindByID
is passed astring
instead of anumber
)Here's an example of a
CollectionConfig
that would be affected:See this Discord thread for additional context.
How?
Just use an
undefined
return, like the subsequent check forfieldAffectsData
.