Fixing CSS (#9) and clear vendor prefixes #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing #9 Using fixed height is not good idea if you plan to expand the input using paddings. I removed the height since is not needed. If you prefer height, just remove padding top/bottom and center the text using another method, but this is just easier. Also, the icon doesn't need padding because is non-sense. Just correct the top/right properties to position it where you want
Those prefixes are not needed anymore. Leaving -webkit-transition because of android 4.2 which has a market share of 0.88%.
|
I made two separate commits just in case you don't want to remove prefixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9 and also clear unused vendor prefixes