Skip to content

Append slash only if the queryParamName is not defined #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Append slash only if the queryParamName is not defined #30

wants to merge 2 commits into from

Conversation

fortis
Copy link

@fortis fortis commented Aug 19, 2016 •
edited
Loading

Seems that we should append slash in the case when query is not used as GET parameter

fortis added 2 commits August 20, 2016 01:05
@fortis
Append slash only if queryParamName is not defined
2ca5b0c 
Seems that we should append slash in the case when query is not used as GET parameter
@fortis
Fix condition
95ec1fc
@pespantelis
Copy link
Owner

Hi @fortis,

In the case that was described in the issue #34, your fix does not work.
So, I decided to revert the related commit (4ab64b6).

Thanks for the interest and sorry for the delayed response!

@pespantelis pespantelis closed this Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fortis @pespantelis