Skip to content

feat(impact): document types of impact #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 3, 2025

Conversation

btry
Copy link
Contributor

@btry btry commented Jun 4, 2025

No description provided.

Boaviztapi
^^^^^^^^^^

Boaviztapi is a tool produced by Boavizta, an association helping organizations to assess, manage and reduce the environmental impact of their digital in a simple, fast and reliable way.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"reduce the environmental impact of their digital in a simple"

This doesn't make sense in English. "digital" isn't a noun but follows a possessive pronoun. Since "digital" isn't a thing but rather describes something, a noun needs to follow "digital".


Boaviztapi is a tool produced by Boavizta, an association helping organizations to assess, manage and reduce the environmental impact of their digital in a simple, fast and reliable way.

It maintains a tool which calculates impacts of digital assets from its internal database. The Carbon plugin sends queries to this tool to get metrics which are locally saved and agregated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"IT" is not a pronoun used for people, but also this sentence seems partially redundant with the one before. Maybe they can be combined to:

Boaviztapi is a tool produced by Boavizta, an association helping organizations to assess, manage and reduce their environmental impact. The carbon plugin sends queries to this tool to get metrics to calculate the impact of digital assets in a simple, fast and reliable way.

Usage impacts
----------------

The plugin calculates internally the emissions of C0_2Eq, using carbon intensity of local electricity of each assset. Other impacts are calculated by external tools.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The plugin calculates internally the emissions of C0_2Eq, using carbon intensity of local electricity of each assset. Other impacts are calculated by external tools.
The plugin internally calculates the emissions of C0_2Eq, using the carbon intensity of the local electricity supplier of each asset. Other impacts are calculated by external tools.

btry and others added 8 commits June 25, 2025 15:08
Co-authored-by: Curtis Conard <cconard96@gmail.com>
Co-authored-by: Curtis Conard <cconard96@gmail.com>
Co-authored-by: Curtis Conard <cconard96@gmail.com>
Co-authored-by: Curtis Conard <cconard96@gmail.com>
Co-authored-by: Curtis Conard <cconard96@gmail.com>
Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New pages must be added to tx configuration.

@trasher trasher requested a review from cconard96 July 3, 2025 08:08
Co-authored-by: Johan Cwiklinski <trasher@x-tnd.be>
@trasher trasher merged commit 8aff70c into pluginsGLPI:carbon Jul 3, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants