-
Notifications
You must be signed in to change notification settings - Fork 150
Open
Labels
Description
Since Python 3.5 reached its end of life in September 2020, I would recommend phasing it out like this:
- In v1.1, a
DeprecationWarningshould be included and prompted in Python 3.5 - From v1.2, the minimum supported version should be 3.6
fantix
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
Chaostheorie commentedon May 22, 2021
On that note, the testing for 3.5 could also be dropped from CI to reduce workflow time. Will create a PR for this
kigawas commentedon May 24, 2021
There's no hurt including 3.5 on CI, but it does need to include 3.9 since it's the current stable version.
Chaostheorie commentedon May 24, 2021
3.9 is already in tests. Added it to coverage in the above-mentioned PR. My reason for removing python 3.5 from the CI is, that testing for another version costs a lot of resources due to cross-testing strategy of GINO. At the moment we not only test each version 3.5-9 for 3 Postgres versions plus some other stuff.
Chaostheorie commentedon May 27, 2021
Created PR with warning for python 3.6 and lower. @kigawas is the PR to your expectations or are there adjustments required?
kigawas commentedon May 27, 2021
Not exactly. You should use this:
https://docs.python.org/3/library/exceptions.html#DeprecationWarning
Chaostheorie commentedon May 28, 2021
Okay, going to try to use this instead. Might try to apply it this evening.
EDIT: That was easier than I had thought. Changes were made to PR. It now uses
warnings. Tests are passing so far. All good then @kigawas ?kigawas commentedon May 28, 2021
You should use sys.version_info instead and there is no need to catch exception
Chaostheorie commentedon May 29, 2021
I will make the adjustments later though next time you see something just list all the problems. It's easier and faster to fix that way. Anyways, Thanks for your help, has been long since I've worked with python version warnings.
Chaostheorie commentedon May 30, 2021
Changes done. Tests are running