Skip to content

Phase out Python 3.5 #731

@kigawas

Description

@kigawas
Contributor

Since Python 3.5 reached its end of life in September 2020, I would recommend phasing it out like this:

  1. In v1.1, a DeprecationWarning should be included and prompted in Python 3.5
  2. From v1.2, the minimum supported version should be 3.6

Activity

Chaostheorie

Chaostheorie commented on May 22, 2021

@Chaostheorie
Contributor

On that note, the testing for 3.5 could also be dropped from CI to reduce workflow time. Will create a PR for this

kigawas

kigawas commented on May 24, 2021

@kigawas
ContributorAuthor

On that note, the testing for 3.5 could also be dropped from CI to reduce workflow time. Will create a PR for this

There's no hurt including 3.5 on CI, but it does need to include 3.9 since it's the current stable version.

Chaostheorie

Chaostheorie commented on May 24, 2021

@Chaostheorie
Contributor

3.9 is already in tests. Added it to coverage in the above-mentioned PR. My reason for removing python 3.5 from the CI is, that testing for another version costs a lot of resources due to cross-testing strategy of GINO. At the moment we not only test each version 3.5-9 for 3 Postgres versions plus some other stuff.

Chaostheorie

Chaostheorie commented on May 27, 2021

@Chaostheorie
Contributor

Created PR with warning for python 3.6 and lower. @kigawas is the PR to your expectations or are there adjustments required?

kigawas

kigawas commented on May 27, 2021

@kigawas
ContributorAuthor
Chaostheorie

Chaostheorie commented on May 28, 2021

@Chaostheorie
Contributor

Okay, going to try to use this instead. Might try to apply it this evening.
EDIT: That was easier than I had thought. Changes were made to PR. It now uses warnings. Tests are passing so far. All good then @kigawas ?

kigawas

kigawas commented on May 28, 2021

@kigawas
ContributorAuthor

You should use sys.version_info instead and there is no need to catch exception

Chaostheorie

Chaostheorie commented on May 29, 2021

@Chaostheorie
Contributor

I will make the adjustments later though next time you see something just list all the problems. It's easier and faster to fix that way. Anyways, Thanks for your help, has been long since I've worked with python version warnings.

Chaostheorie

Chaostheorie commented on May 30, 2021

@Chaostheorie
Contributor

Changes done. Tests are running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @wwwjfy@kigawas@Chaostheorie

      Issue actions

        Phase out Python 3.5 · Issue #731 · python-gino/gino