Skip to content

remove torchao dependency from torchao build script #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Jun 16, 2025

Summary:

We should not use torchao to build torchao. Before this PR, I got stuck in a loop where I had a broken install (for some other reason) and could not uninstall torchao with this setup script, because the script required a working torchao to run.

Commenting out the offending code in this PR, leaving for a future person to actually fix it.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Summary:

We should not use torchao to build torchao. Before this PR,
I got stuck in a loop where I had a broken install (for some other
reason) and could not uninstall torchao with this setup script,
because the script required a working torchao to run.

Commenting out the offending code in this PR, leaving for a
future person to actually fix it.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Copy link

pytorch-bot bot commented Jun 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2383

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 507039f with merge base 5bdc25d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 16, 2025
@vkuzo vkuzo added the topic: bug fix Use this tag for PRs that fix bugs label Jun 16, 2025
@vkuzo vkuzo requested review from jerryzh168 and drisspg June 16, 2025 16:31
"-fopenmp",
]
)
# TODO(future PR): make this work without using `TORCH_VERSION_AT_LEAST_2_7`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkuzo vkuzo merged commit d1c8118 into main Jun 17, 2025
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: bug fix Use this tag for PRs that fix bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants