Skip to content

Commit 17fcb46

Browse files
authored
Merge pull request #624 from josdejong/fix/aria_roles
fix: #610 resolve ARIA warnings by defining a role on interactive divs
2 parents 1d96a9f + e543416 commit 17fcb46

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/lib/Select.svelte

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -678,7 +678,8 @@
678678
on:pointerup|preventDefault={handleClick}
679679
on:mousedown|preventDefault
680680
bind:this={container}
681-
use:floatingRef>
681+
use:floatingRef
682+
role="none">
682683
{#if listOpen}
683684
<div
684685
use:floatingContent
@@ -697,7 +698,8 @@
697698
on:click|stopPropagation={() => handleItemClick({ item, i })}
698699
on:keydown|preventDefault|stopPropagation
699700
class="list-item"
700-
tabindex="-1">
701+
tabindex="-1"
702+
role="none">
701703
<div
702704
use:activeScroll={{ scroll: isItemActive(item, value, itemId), listDom }}
703705
use:hoverScroll={{ scroll: scrollToHoverItem === i, listDom }}
@@ -745,7 +747,8 @@
745747
class:active={activeValue === i}
746748
class:disabled
747749
on:click|preventDefault={() => (multiFullItemClearable ? handleMultiItemClear(i) : {})}
748-
on:keydown|preventDefault|stopPropagation>
750+
on:keydown|preventDefault|stopPropagation
751+
role="none">
749752
<span class="multi-item-text">
750753
<slot name="selection" selection={item} index={i}>
751754
{item[label]}

0 commit comments

Comments
 (0)