add input hidden slot #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Ennoriel thanks! I'm away for the long weekend but will take a look on Tuesday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 😃
Here is a PR intended to add the input hidden slot discussed in #579.
I added the doc and a test as well. However I wasn't able to launch the doc site and only ran the test until the end. Be sure to double check before merging ;)
I had troubled launching with pnpm (
module not foundlinked to thehighlightplugin) and the npm (no such file or directory, open 'D:\perso\svelte-select\src\lib\no-styles\D:\perso\svelte-select\src\lib\Select.svelte')Have a nice day :)