-
Notifications
You must be signed in to change notification settings - Fork 65
Add PT-BR automatic translation softwarereview_intro.pt.Rmd #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Vou fazer a primeira revisão! |
@yabellini considering my first review, can you please mark need second review? |
Thanks @rffontenelle !! Status changed 😄 |
@rffontenelle where we can see your first review? |
@beatrizmilz I actually barely started and stopped. So please feel free to proceed reviewing this. @yabellini So, we are actually in need of the first review. You may want to undo the labels changes. Sorry for the noise! |
No problem at all! |
The first review is happening here: https://github.com/ropensci/dev_guide/pull/852/files by @beatrizmilz |
If it's a need, I can do the second review. |
Hi @brunomioto ! Thanks for your offer. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yabellini ! I have migrated all the comments/suggestions from #852 to this PR. Is that ok? I think it will be easier for us to follow up the review here.
And since this PR is older, I don't remember why I did create a new (#852) in the first place.
I will copy the message I have left in the other PR:
Hi! I have finished the first review of this chapter.
I have based the review of the translation for this document: https://raw.githubusercontent.com/ropensci/dev_guide/refs/heads/main/softwarereview_intro.Rmd - there are some things that were diferent (probably because this branch was from some months ago) and I have used that file to check if anything needed to be updated.
I have left some comments in the translation so we can discuss.
softwarereview_intro.pt.Rmd
Outdated
### Editores associados {#associateditors} | ||
|
||
O processo de revisão por pares de software da rOpenSci é conduzido por: | ||
|
||
```{r} | ||
#| child: "associate-editors.md" | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is quite different because the file in English has been updated since the begining of the translation process:
https://github.com/ropensci/dev_guide/blob/main/softwarereview_intro.Rmd
### Editores associados {#associateditors} | |
O processo de revisão por pares de software da rOpenSci é conduzido por: | |
```{r} | |
#| child: "associate-editors.md" | |
``` | |
### Equipe editorial | |
Nossa equipe atual de editores(as) para revisão por pares de software inclui: | |
```{r} | |
#| echo: false | |
#| results: 'asis' | |
if (nzchar(Sys.getenv("AIRTABLE_API_KEY"))) { | |
source(file.path("scripts", "airtable-get-editors.R"), local = knitr::knit_global()) | |
} else { | |
cat("_No Airtable data available._") | |
} | |
``` |
Thank you @beatrizmilz ! This is ready for your review @fblpalmeira . |
Co-authored-by: Beatriz Milz <42153618+beatrizmilz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maelle @yabellini @beatrizmilz Apologies for the delay in submitting the review. I was finally able to review the chapter attentively!
Done! |
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Thank you😎🥳 |
@maelle can you check why is failling to build the book? The log mention an error with the gen_ed_out() funciton between the lines 100 and 106. Thanks! |
I'll just try merging it |
No description provided.