-
Notifications
You must be signed in to change notification settings - Fork 65
Fix typos and improve grammar in pkg_building.Rmd #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @Moohan for your contribution, which we both encourage and appreciate. In this case, however, the PR includes too many changes for us to include straight off. A few of your suggestions and typo-fixes are good and helpful, but many of your suggestions are stylistic, and some go against our general style. Feel free to retain your own record of all changes included here, but in the meantime could you please reduce the PR to the following reduced set of changes on line numbers:
Thanks again for your contribution, which we'll definitely include once we're all in agreement here. Also note for future reference that no change is too small, and it is generally much easier for us to respond to smaller pull requests than ones of this size. Once we've reduced this one, you should feel free to suggest any additional changes via separate PRs. |
👋 @Moohan is any help needed, for instance with the Git aspects of selecting part of the changes? |
Thank you!! |
@mpadge - apologies for the long delay. I think that's my changes pruned down per your request, and it all properly rebased onto the current version of main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! I added a news item via your other PR. |
No description provided.