Skip to content

Fix Issue #884 update typeAheadPointer when dropdown open. #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ocomsoft
Copy link

This fixes issue #884 by setting the typeAheadpointer to the index then the Drop down is open and scrolling into position.

@ocomsoft
Copy link
Author

I believe this fixes issue #1169 also.

@amulchinock
Copy link

amulchinock commented Jan 28, 2021

I believe this fixes issue #1169 also.

Not sure it does. Currently using version 3.11.2 - and there is no .vs__dropdown-option--selected class applied to any list options on initially opening. Will add this information to #1169 also.

Edit: sorry - didn't see that this hadn't been merged into master yet. Looking at the diff, it seems this might actually fix the issue. My bad.

@amulchinock
Copy link

@sagalbot is there an ETA for merging this in? It’s been sat here for over a year now - and addresses multiple problems.

If you need volunteer help with maintenance, let me know. Would love to get some of these things unstuck. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants