Skip to content

Added aria-owns link between input and dropdown list #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beattyml1
Copy link
Contributor

Added aria-owns link between input and dropdown list, had to add unique ID generator and a switch v-if to v-show to make that really work.

…ue ID generator and a switch v-if to v-show to make that really work
@sagalbot
Copy link
Owner

sagalbot commented Aug 7, 2018

Ahhh.. this is challenging. v-show was originally used, but swapped for v-if after it became apparent that v-show causes significant performance issues when rending multiple selects on a given page, especially if each one has hundreds or thousands of options to search through. v-show results in many extra dom nodes that impact performance.

I suppose aria-owns is invalid if the ID it's referencing doesn't exist?

@beattyml1
Copy link
Contributor Author

I assumed it was but as I think about it I feel like if it's not there while the screen reader may not feel existentially happy it also probably isn't going to cause any bugs. My guess is technically invalid but all screen readers would still do their thing which to me is what we really care about. I'll switch it back to v-if and recheck the screen reader.

@sagalbot
Copy link
Owner

sagalbot commented Aug 8, 2018

Awesome, thanks so much @beattyml1!

@beattyml1
Copy link
Contributor Author

A quick update I've determined that v-shows definitely doesn't work quite as well as v-if and have tried to find a work around. I also tried doing some further screen reader testing and covered another screen reader issue that I was planning to resolve at the same time and update the PR when I get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants