Skip to content

don't pre-highlight on focus, because if it's after a search, it's possibly wrong #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

killroyboy
Copy link

This problem is mostly apparent when using selectOnTab, because tabbing into and out of the field would change the value it to the highlighted option.

@sagalbot sagalbot added this to the v2.6 milestone Feb 9, 2019
@sagalbot sagalbot self-assigned this Feb 9, 2019
@sagalbot
Copy link
Owner

sagalbot commented Feb 9, 2019

This is an interesting one. I checked Select2 and the browser select - they implement the current UX, but I see what you mean about selectOnTab. Should we change this behavior only when selectOnTab is true?

@sagalbot sagalbot modified the milestones: v2.6, v3.0 Feb 11, 2019
@killroyboy
Copy link
Author

@sagalbot I'm fine with that distinction. We only run into this problem with selectOnTab is true.

# Conflicts:
#	dist/vue-select.js
#	dist/vue-select.js.map
@coveralls
Copy link

coveralls commented Apr 16, 2019

Coverage Status

Coverage increased (+0.04%) to 96.465% when pulling b44ec4c on killroyboy:master into 8ef15a1 on sagalbot:master.

@sagalbot sagalbot modified the milestones: v3.0, v3.3 Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants