-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Improved Internationalization #988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
What's the status on this PR? |
Any updates for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really clean approach 💯🤩
Will this PR be reconsidered for future releases of vue-select? |
Co-authored-by: Sølve Tornøe <solve@tornoee.com>
commit 23feaad Author: Jeff Sagal <sagalbot@gmail.com> Date: Sun Aug 1 11:45:49 2021 -0700 Update package.json commit 69d11c7 Author: Jeff Sagal <sagalbot@gmail.com> Date: Sun Aug 1 11:42:38 2021 -0700 update eslint config commit 96819eb Author: Jeff Sagal <sagalbot@gmail.com> Date: Fri Jul 30 11:01:59 2021 -0700 build: add prettier and eslint (#1090) commit f702040 Author: semantic-release-bot <semantic-release-bot@martynus.net> Date: Fri Jul 30 00:38:55 2021 +0000 chore(🚀): 3.12.2 commit 0f763f3 Author: Daniel Molnar <dm@tpwd.de> Date: Fri Jul 30 02:37:49 2021 +0200 fix: set !default for $vs-controls-deselect-text-shadow (#1468) - added missing `!default` for $vs-controls-deselect-text-shadow, which was the only one not having it - `!default` is necessary in order to be able override the variable commit 335920b Author: semantic-release-bot <semantic-release-bot@martynus.net> Date: Thu Jul 22 21:41:39 2021 +0000 chore(🚀): 3.12.1 commit 5e1ac1f Author: Jeff Sagal <sagalbot@gmail.com> Date: Thu Jul 22 14:40:29 2021 -0700 fix: no-options slot should use mutableLoading instead of loading prop (#1465)
export default { | ||
components: { SpanishSelect }, | ||
} | ||
</script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last thing to do is to fix this example - it gets overridden by the default vue select component registration.
Based off the work in #741. Rebuilding here to avoid some pretty hectic conflicts.
Closes #548