Skip to content

Improved Internationalization #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Improved Internationalization #988

wants to merge 17 commits into from

Conversation

sagalbot
Copy link
Owner

@sagalbot sagalbot commented Nov 9, 2019

Based off the work in #741. Rebuilding here to avoid some pretty hectic conflicts.


Closes #548

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 96.053% when pulling c40e53f on customizable-text into fb85715 on master.

@sagalbot sagalbot added this to the v3.3 milestone Nov 9, 2019
@sagalbot sagalbot self-assigned this Mar 6, 2020
@sagalbot sagalbot linked an issue Mar 8, 2020 that may be closed by this pull request
@skipworkgh
Copy link

What's the status on this PR?

@jja-financial-com
Copy link

Any updates for this PR?

Copy link
Contributor

@kamerat kamerat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really clean approach 💯🤩

@sagalbot sagalbot removed this from the v3.3 milestone Dec 22, 2020
@sagalbot sagalbot linked an issue Dec 23, 2020 that may be closed by this pull request
@bcartier
Copy link

Will this PR be reconsidered for future releases of vue-select?

sagalbot and others added 11 commits July 27, 2021 20:38
Co-authored-by: Sølve Tornøe <solve@tornoee.com>
commit 23feaad
Author: Jeff Sagal <sagalbot@gmail.com>
Date:   Sun Aug 1 11:45:49 2021 -0700

    Update package.json

commit 69d11c7
Author: Jeff Sagal <sagalbot@gmail.com>
Date:   Sun Aug 1 11:42:38 2021 -0700

    update eslint config

commit 96819eb
Author: Jeff Sagal <sagalbot@gmail.com>
Date:   Fri Jul 30 11:01:59 2021 -0700

    build: add prettier and eslint (#1090)

commit f702040
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Fri Jul 30 00:38:55 2021 +0000

    chore(🚀): 3.12.2

commit 0f763f3
Author: Daniel Molnar <dm@tpwd.de>
Date:   Fri Jul 30 02:37:49 2021 +0200

    fix: set !default for $vs-controls-deselect-text-shadow (#1468)

    - added missing `!default` for $vs-controls-deselect-text-shadow,
      which was the only one not having it
    - `!default` is necessary in order to be able override the variable

commit 335920b
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Thu Jul 22 21:41:39 2021 +0000

    chore(🚀): 3.12.1

commit 5e1ac1f
Author: Jeff Sagal <sagalbot@gmail.com>
Date:   Thu Jul 22 14:40:29 2021 -0700

    fix: no-options slot should use mutableLoading instead of loading prop (#1465)
export default {
components: { SpanishSelect },
}
</script>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last thing to do is to fix this example - it gets overridden by the default vue select component registration.

@sagalbot sagalbot linked an issue Aug 23, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants